Bugzilla – Attachment 1342 Details for
Bug 1322
pam_end() is not called if authentication fails, which breaks pam-abl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Allow PAM cleanup for unathenticated connections based on previous
openssh-pam-cleanup.patch (text/plain), 953 bytes, created by
Darren Tucker
on 2007-08-15 23:51:33 AEST
(
hide
)
Description:
Allow PAM cleanup for unathenticated connections based on previous
Filename:
MIME Type:
Creator:
Darren Tucker
Created:
2007-08-15 23:51:33 AEST
Size:
953 bytes
patch
obsolete
>Index: session.c >=================================================================== >RCS file: /var/cvs/openssh/session.c,v >retrieving revision 1.352 >diff -u -p -r1.352 session.c >--- session.c 13 Aug 2007 13:11:56 -0000 1.352 >+++ session.c 15 Aug 2007 13:42:48 -0000 >@@ -2478,8 +2478,19 @@ do_cleanup(Authctxt *authctxt) > return; > called = 1; > >- if (authctxt == NULL || !authctxt->authenticated) >+ if (authctxt == NULL) > return; >+ >+#ifdef USE_PAM >+ if (options.use_pam) { >+ sshpam_cleanup(); >+ sshpam_thread_cleanup(); >+ } >+#endif >+ >+ if (!authctxt->authenticated) >+ return; >+ > #ifdef KRB5 > if (options.kerberos_ticket_cleanup && > authctxt->krb5_ctx) >@@ -2489,13 +2500,6 @@ do_cleanup(Authctxt *authctxt) > #ifdef GSSAPI > if (compat20 && options.gss_cleanup_creds) > ssh_gssapi_cleanup_creds(); >-#endif >- >-#ifdef USE_PAM >- if (options.use_pam) { >- sshpam_cleanup(); >- sshpam_thread_cleanup(); >- } > #endif > > /* remove agent socket */
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1342">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
djm
:
ok+
Actions:
View
|
Diff
Attachments on
bug 1322
:
1307
|
1308
|
1325
|
1339
| 1342