Bugzilla – Attachment 1415 Details for
Bug 1419
Fix PTY handling on Mac OS X
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Corrects PTY handling.
sshpty.c.patch (text/plain), 792 bytes, created by
Disco Vince Giffin
on 2007-12-21 15:45:00 AEDT
(
hide
)
Description:
Corrects PTY handling.
Filename:
MIME Type:
Creator:
Disco Vince Giffin
Created:
2007-12-21 15:45:00 AEDT
Size:
792 bytes
patch
obsolete
>--- sshpty.c.orig 2006-01-24 23:45:13.000000000 -0800 >+++ sshpty.c 2006-01-24 23:50:08.000000000 -0800 >@@ -41,17 +41,18 @@ > pty_allocate(int *ptyfd, int *ttyfd, char *namebuf, int namebuflen) > { > /* openpty(3) exists in OSF/1 and some other os'es */ >- char *name; >+ /* >+ * ttyname() may fail due to different sshd code paths. However, >+ * we can just get the tty name from openpty() and avoid ttyname(). >+ */ >+ char name[64]; > int i; > >- i = openpty(ptyfd, ttyfd, NULL, NULL, NULL); >+ i = openpty(ptyfd, ttyfd, name, NULL, NULL); > if (i < 0) { > error("openpty: %.100s", strerror(errno)); > return 0; > } >- name = ttyname(*ttyfd); >- if (!name) >- fatal("openpty returns device for which ttyname fails."); > > strlcpy(namebuf, name, namebuflen); /* possible truncation */ > return 1;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1415">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1419
:
1415
|
1416
|
1439
|
1593
|
1594