Attachment 2147 Details for Bug 2002 – Patch fixing memory leak

[patch] Patch fixing memory leak

0001-mux-fix-memory-leak-of-control-path-if-bind-fails.patch (text/plain), 990 bytes, created by Bert Wesarg on 2012-05-03 04:00:39 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Bert Wesarg

Created: 2012-05-03 04:00:39 AEST

Size: 990 bytes

patch

obsolete

>From 3aaa51afd883ceb37ec351a1bed24e8ba7a5883a Mon Sep 17 00:00:00 2001
>Message-Id: <3aaa51afd883ceb37ec351a1bed24e8ba7a5883a.1335518820.git.bert.wesarg@googlemail.com>
>From: Bert Wesarg <bert.wesarg@googlemail.com>
>Date: Fri, 27 Apr 2012 11:21:22 +0200
>Subject: [PATCH] mux: fix memory leak of control path if bind() fails
>
>---
> mux.c |    2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/mux.c b/mux.c
>index d90605e..fa796bd 100644
>--- a/mux.c
>+++ b/mux.c
>@@ -1195,6 +1195,7 @@ muxserver_listen(void)
> 				close(muxserver_sock);
> 				muxserver_sock = -1;
> 			}
>+			xfree(orig_control_path);
> 			xfree(options.control_path);
> 			options.control_path = NULL;
> 			options.control_master = SSHCTL_MASTER_NO;
>@@ -1216,7 +1217,6 @@ muxserver_listen(void)
> 		}
> 		error("ControlSocket %s already exists, disabling multiplexing",
> 		    orig_control_path);
>-		xfree(orig_control_path);
> 		unlink(options.control_path);
> 		goto disable_mux_master;
> 	}
>-- 
>1.7.9.rc0.542.g07ca1
>

Actions: View | Diff

Attachments on bug 2002: 2147