| Summary: | get_remote_hostname() potentially passing uninitialised buffer to debug | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | David Leonard <David.Leonard> | ||||
| Component: | ssh | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | minor | ||||||
| Priority: | P2 | ||||||
| Version: | 4.2p1 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 1047 | ||||||
| Attachments: |
|
||||||
Created attachment 966 [details]
relocate check_ip_options call.
The obvious fix would seem to be a relocation of the check_ip_options call.
Patch applied, thanks for the report. Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4. |
get_remote_hostname() calls check_ip_options(..., ntop) but, at that point, ntop is an uninitialised auto. check_ip_options(, ipaddr) then calls logit("...%.100s..", ipaddr) which will log some binary garbage.