Bug 1588

Summary: sftp client produces unnecessary message upon connecting to host
Product: Portable OpenSSH Reporter: J.A. Neitzel <gsocsftp>
Component: sftpAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: normal CC: djm
Priority: P2    
Version: 5.2p1   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 1626    
Attachments:
Description Flags
Patch to remove "Connecting to <host>..." message from sftp.c
none
Patch to remove "Connecting to <host>..." message from sftp.c
none
delay printing connect message until after sftp protocol is raised dtucker: ok+

Description J.A. Neitzel 2009-04-07 14:36:00 AEST 

    


    


      



        
          Comment 1
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 14:43:43 AEST
        

      






Created attachment 1624 [details]
Patch to remove "Connecting to <host>..." message from sftp.c

This patch is for Portable OpenSSH.

    


    


      



        
          Comment 2
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 14:45:34 AEST
        

      






Created attachment 1625 [details]
Patch to remove "Connecting to <host>..." message from sftp.c

This patch is for usr.bin/ssh/sftp.c in the OpenBSD source tree.

    


    


      



        
          Comment 3
        

        
          J.A. Neitzel

        

        
        

        
          2009-04-07 15:00:31 AEST
        

      






In response to this message to the openssh-unix-dev mailing list:
https://lists.mindrot.org/pipermail/openssh-unix-dev/2009-April/027560.html
.

The removal of this message should be OK.
There is a corresponding message in the debug1 output
when user invokes sftp(1) as `sftp -v ...' .

    


    


      



        
          Comment 4
        

        
          J.A. Neitzel

        

        
        

        
          2009-05-01 22:46:34 AEST
        

      






Reset assignee to default.
Reset status to new.

    


    


      



        
          Comment 5
        

        
          Damien Miller

        

        
        

        
          2009-10-06 15:18:14 AEDT
        

      






yeah, this log line doesn't actually give you any additional information (unlike, e.g., telnet's) so I don't see any harm in nuking it, or perhaps delaying it until after the connection has been confirmed (i.e. after sftp-client.c:do_init() has returned.)

    


    


      



        
          Comment 6
        

        
          Damien Miller

        

        
        

        
          2009-11-20 11:29:33 AEDT
        

      






Created attachment 1724 [details]
delay printing connect message until after sftp protocol is raised

This delays printing the message until after the sftp session has been established (post do_init()):

djm@localhost's password:
Connected to fuyu.
sftp>

    


    


      



        
          Comment 7
        

        
          Damien Miller

        

        
        

        
          2009-11-20 11:54:20 AEDT
        

      






patch has been applied. will be in openssh-5.4

    


    


      



        
          Comment 8
        

        
          Darren Tucker

        

        
        

        
          2010-03-26 10:51:58 AEDT
        

      






With the release of 5.4p1, this bug is now considered closed.