Bug 1875

Summary:	Gentoo QA warning: net-misc/openssh-5.8_p1-r1: closefromtest.c:46: warning: implicit declaration of function ‘closefrom’
Product:	Portable OpenSSH	Reporter:	Dan Wallis <mrdanwallis>
Component:	Build system	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED FIXED
Severity:	minor	CC:	djm, dtucker
Priority:	P2
Version:	5.8p1
Hardware:	All
OS:	Linux
Bug Depends on:
Bug Blocks:	1845

Description Dan Wallis 2011-03-04 21:46:57 AEDT

When installing the net-misc/openssh-5.8_p1-r1 package on my Gentoo system, I received the following notification:

 * QA Notice: Package has poor programming practices which may compile
 *            fine but exhibit random runtime failures.
 * closefromtest.c:46: warning: implicit declaration of function ‘closefrom’

 * Please do not file a Gentoo bug and instead report the above QA
 * issues directly to the upstream developers of this software.
 * Homepage: http://www.openssh.org/
 * ERROR: net-misc/openssh-5.8_p1-r1 failed:
 *   install aborted due to poor programming practices shown above



Looking through the build output, here is the warning in context:

make[1]: Leaving directory `/var/tmp/portage/net-misc/openssh-5.8_p1-r1/work/openssh-5.8p1/openbsd-compat'
(cd openbsd-compat/regress && make)
make[1]: Entering directory `/var/tmp/portage/net-misc/openssh-5.8_p1-r1/work/openssh-5.8p1/openbsd-compat/regress'
i686-pc-linux-gnu-gcc -O2 -march=i686 -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign -Wno-unused-result -fno-strict-ali
asing -fno-builtin-memset -fstack-protector-all  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -Wl,-O1 -Wl,--as-needed -fstack-protector-all -Wl,-O1 -Wl,--as-needed ../libopenb
sd-compat.a -o closefromtest closefromtest.c ../libopenbsd-compat.a -lresolv -lssl -lcrypto -ldl -lz   -ldl -lldap -lutil -lz -lnsl  -lcrypt
closefromtest.c: In function ‘main’:
closefromtest.c:46: warning: implicit declaration of function ‘closefrom’
At top level:
cc1: warning: unrecognized command line option "-Wno-unused-result"
i686-pc-linux-gnu-gcc -O2 -march=i686 -pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare -Wformat-security -Wno-pointer-sign -Wno-unused-result -fno-strict-aliasing -fno-builtin-memset -fstack-protector-all  -I. -I.. -I. -I./..  -DHAVE_CONFIG_H -Wl,-O1 -Wl,--as-needed -fstack-protector-all -Wl,-O1 -Wl,--as-needed ../libopenbsd-compat.a -o snprintftest snprintftest.c ../libopenbsd-compat.a -lresolv -lssl -lcrypto -ldl -lz   -ldl -lldap -lutil -lz -lnsl  -lcrypt

Comment 1 Damien Miller 2011-04-19 15:58:36 AEST

Darren, can we just add a closefrom() prototype to the top of the file? I.e.

int closefrom(int);

I can't imagine it being prototyped any other way.

Comment 2 Darren Tucker 2011-05-06 10:44:27 AEST

Done and committed, it will be in the 5.9 release.

Thanks.

Comment 3 Damien Miller 2011-09-06 15:32:59 AEST

close resolved bugs now that openssh-5.9 has been released