| Summary: | sshd accepts empty arguments in ForceCommand and VersionAddendum | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Petr Lautrbach <plautrba> | ||||
| Component: | sshd | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | normal | CC: | djm, dtucker | ||||
| Priority: | P5 | ||||||
| Version: | 6.6p1 | ||||||
| Hardware: | Other | ||||||
| OS: | Linux | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2360 | ||||||
| Attachments: |
|
||||||
Comment on attachment 2481 [details]
check for empty arguments in VersionAddendum and ForceCommand
I think we'd also need to add "ForcedCommand none" to allow you to unset it in a Match block.
Patch applied and will be in the 6.9 release. Thanks. Set all RESOLVED bugs to CLOSED with release of OpenSSH 7.1 |
Created attachment 2481 [details] check for empty arguments in VersionAddendum and ForceCommand When the mentioned options are specified with white spaces, they are accepted by the parser. There are missing checks for empty strings in cp. # /usr/sbin/sshd -o "ForceCommand " -t # /usr/sbin/sshd -o "ForceCommand" -t command-line line 0: Missing argument. The attached patch fixes it.