Bug 2507

Summary: missing or misleading error messages
Product: Portable OpenSSH Reporter: Tomas Kuthan <tomas.kuthan>
Component: sshAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: normal CC: djm, flavio.gallucci
Priority: P5    
Version: 7.1p1   
Hardware: SPARC   
OS: Solaris   
Bug Depends on:    
Bug Blocks: 2451    
Attachments:
Description Flags
Call error() on identity_sign() failure, fix typos in ssherr() calls. none

Description Tomas Kuthan 2015-11-27 02:04:00 AEDT 
After code refactoring for library-like interfaces, error messages are no longer printed for DSA_do_sign() or RSA_sign() failures in some code paths.

When investigating error messaging for signing failures I also noticed, that incorrect messages are printed for sshkey_from_blob() and sshkey_sign() errors in ssh-agent.c.
Comment 1 Tomas Kuthan 2015-11-27 02:06:16 AEDT 
Created attachment 2758 [details]
Call error() on identity_sign() failure, fix typos in ssherr() calls.
Comment 2 flavio.gallucci 2015-11-28 23:42:07 AEDT 
openssh 6x doesn't give this problem.
Comment 3 Damien Miller 2015-12-11 13:20:58 AEDT 
Patch applied - thanks. This will be in the OpenSSH 7.2 release.
Comment 4 Damien Miller 2016-08-02 10:40:49 AEST 
Close all resolved bugs after 7.3p1 release