Bug 2604

Summary: Remove orphaned do_pam_set_tty() or make use of it
Product: Portable OpenSSH Reporter: Jakub Jelen <jjelen>
Component: PAM supportAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: enhancement CC: dtucker
Priority: P5    
Version: 7.3p1   
Hardware: Other   
OS: Linux   
Bug Depends on:    
Bug Blocks: 2594    

Description Jakub Jelen 2016-08-16 01:23:30 AEST 
today I ran into problems with PAM and bumped into the function do_pam_set_tty(), which is defined, but never used, if I see right:

$ git grep do_pam_set_tty
auth-pam.c:do_pam_set_tty(const char *tty)
auth-pam.h:void do_pam_set_tty(const char *);

There is basically duplicate code in sshpam_init(). In the git, last usage of this function was removed in 2008 [1]. I don't think it makes sense to keep it.


[1] https://github.com/openssh/openssh-portable/commit/52358d6d
Comment 1 Darren Tucker 2016-10-15 04:37:11 AEDT 
Done, thanks.
Comment 2 Damien Miller 2021-04-23 15:11:02 AEST 
closing resolved bugs as of 8.6p1 release