| Summary: | Bug compatibility rules incorrectly match WinSCP 5.10.x | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Martin Prikryl <martin> | ||||
| Component: | sshd | Assignee: | Assigned to nobody <unassigned-bugs> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | normal | CC: | djm, dtucker | ||||
| Priority: | P5 | ||||||
| Version: | 7.5p1 | ||||||
| Hardware: | Other | ||||||
| OS: | Other | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 2698 | ||||||
| Attachments: |
|
||||||
Created attachment 3018 [details]
Require exact match or dots for older WinSCP versions.
(In reply to Martin Prikryl from comment #0) > "WinSCP_release_5.0," > "WinSCP_release_5.0.*," That one looks unnecessary unless you have versions numbers with leading zeros (which it seems you don't). Could you please confirm the patch does what you want? Thanks. (In reply to Darren Tucker from comment #2) > (In reply to Martin Prikryl from comment #0) > > "WinSCP_release_5.0," > > "WinSCP_release_5.0.*," > > That one looks unnecessary unless you have versions numbers with > leading zeros (which it seems you don't). True. I've added it just for consistency. (In reply to Darren Tucker from comment #3) > Could you please confirm the patch does what you want? Thanks. There should be a dot, not comma after 1: "WinSCP_release_5.1,*," Like this: "WinSCP_release_5.1.*," (In reply to Martin Prikryl from comment #4) [...] > There should be a dot, not comma after 1: > "WinSCP_release_5.1,*," > Like this: > "WinSCP_release_5.1.*," Fixed. Patch applied and will be in 7.6. Thanks. closing resolved bugs as of 8.6p1 release |
The compat_datafellows function in compat.c includes this rule: { "WinSCP_release_4*," "WinSCP_release_5.0*," "WinSCP_release_5.1*," "WinSCP_release_5.5*," "WinSCP_release_5.6*," "WinSCP_release_5.7," "WinSCP_release_5.7.1," "WinSCP_release_5.7.2," "WinSCP_release_5.7.3," "WinSCP_release_5.7.4", SSH_OLD_DHGEX }, Unfortunately the "WinSCP_release_5.1*" mask inadvertently matches even the latest branch of WinSCP 5.10 with version string like "WinSCP_release_5.10.4". Can you please change the masks to require a dot? { "WinSCP_release_4*," "WinSCP_release_5.0," "WinSCP_release_5.0.*," "WinSCP_release_5.1," "WinSCP_release_5.1.*," "WinSCP_release_5.5," "WinSCP_release_5.5.*," "WinSCP_release_5.6," "WinSCP_release_5.6.*," "WinSCP_release_5.7," "WinSCP_release_5.7.1," "WinSCP_release_5.7.2," "WinSCP_release_5.7.3," "WinSCP_release_5.7.4", SSH_OLD_DHGEX }, Thanks.