Bug 2921

Summary: fix compilation --with-ssl-engine
Product: Portable OpenSSH Reporter: cotequeiroz <cote2004-github>
Component: MiscellaneousAssignee: Assigned to nobody <unassigned-bugs>
Status: CLOSED FIXED    
Severity: normal CC: ahmedsayeed1982, djm, jbrown, openssh
Priority: P5    
Version: -current   
Hardware: All   
OS: Linux   
Bug Depends on:    
Bug Blocks: 2915    
Attachments:
Description Flags
fix OPENSSL_VERSION number in openssl-compat.c none

Description cotequeiroz 2018-10-20 00:20:57 AEDT
Created attachment 3194 [details]
fix OPENSSL_VERSION number in openssl-compat.c

openssl version number is wrong in openbsd-compat/openssl-compat.c,  ssh_OpenSSL_add_all_algorithms(void)

The result is that compilation fails with openssl < 1.1.0:

openssl-compat.c: In function 'ssh_OpenSSL_add_all_algorithms':
openssl-compat.c:82:2: warning: implicit declaration of function 'OPENSSL_init_crypto'; did you mean 'OPENSSL_init'? [-Wimplicit-function-declaration]
  OPENSSL_init_crypto(OPENSSL_INIT_ADD_ALL_CIPHERS |
  ^~~~~~~~~~~~~~~~~~~
  OPENSSL_init
openssl-compat.c:82:22: error: 'OPENSSL_INIT_ADD_ALL_CIPHERS' undeclared (first use in this function); did you mean 'OPENSSL_NO_WEAK_SSL_CIPHERS'?
  OPENSSL_init_crypto(OPENSSL_INIT_ADD_ALL_CIPHERS |
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
                      OPENSSL_NO_WEAK_SSL_CIPHERS
Comment 1 Damien Miller 2018-10-22 11:24:42 AEDT
ugh.

Thanks. I've applied this patch to the master and V_7_9 branches.
Comment 2 Damien Miller 2018-11-16 13:06:56 AEDT
*** Bug 2931 has been marked as a duplicate of this bug. ***
Comment 3 Darren Tucker 2019-03-13 10:46:17 AEDT
*** Bug 2979 has been marked as a duplicate of this bug. ***
Comment 4 Damien Miller 2019-10-09 15:11:42 AEDT
Close bugs fixed in openssh-8.1 release cycle
Comment 5 Ahmed Sayeed 2021-10-14 01:40:45 AEDT
[spam removed]