| Summary: | Incorrect test against OPENSSL_VERSION_NUMBER | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | David Newall <openssh> | ||||||
| Component: | sshd | Assignee: | Assigned to nobody <unassigned-bugs> | ||||||
| Status: | CLOSED DUPLICATE | ||||||||
| Severity: | normal | CC: | ahmedsayeed1982, djm, dtucker | ||||||
| Priority: | P5 | ||||||||
| Version: | 7.9p1 | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
*** This bug has been marked as a duplicate of bug 2921 *** Created attachment 3206 [details]
Test for OPENSSL_init_crypto before using
I think that where possible we should be testing for the presence of the new thing (and anything else it depends on) rather than inferring it from a version number.
Move resolved bugs -> CLOSED after 8.0 release [spam removed] |
Created attachment 3204 [details] Fix test of OPENSSL_VERSION_NUMBER In openbsd-compat/openssl-compat.c, at line 79, there's a test against OPENSSL_VERSION_NUMBER which determines whether to use OPENSSL_config() or OPENSSL_init_crypto(). The test uses the latter if OpenSSL version is 1.0.1 or greater, but that function was introduced in version 1.1.0.