| Summary: | Custom critical options and extensions are not lexically ordered | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Mariano Cano <mariano.cano> | ||||
| Component: | ssh-keygen | Assignee: | Damien Miller <djm> | ||||
| Status: | CLOSED FIXED | ||||||
| Severity: | normal | CC: | djm, dtucker | ||||
| Priority: | P5 | ||||||
| Version: | -current | ||||||
| Hardware: | amd64 | ||||||
| OS: | Mac OS X | ||||||
| Bug Depends on: | |||||||
| Bug Blocks: | 3162 | ||||||
| Attachments: |
|
||||||
|
Description
Mariano Cano
2020-07-28 07:50:05 AEST
The same will occur on regular extension, PROTOCOL.certkeys states: ... The encoding and ordering of extensions in this field is identical to that of the critical options, as is the requirement that each name appear only once. But a certificate created with the following command will have the specified extension at the end of the standard ones: ssh-keygen -s ca-key -I key-id -O extension:login@github.com=username user-key.pub Created attachment 3434 [details]
explicitly sort certificate extensions sections
Nice catch. This should fix it.
Comment on attachment 3434 [details]
explicitly sort certificate extensions sections
assuming the tests pass :-)
patch applied - thanks Mass close of all bugs fixed in 8.4 release. |