Bug 3244

Summary:	ASAN found two memory leaks in sshd.c
Product:	Portable OpenSSH	Reporter:	filmil+mindrot
Component:	sshd	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	NEW ---
Severity:	enhancement
Priority:	P5
Version:	-current
Hardware:	Other
OS:	Linux

Description filmil+mindrot 2020-12-16 19:54:35 AEDT

An ASAN build of openssh-portable found the following memory leaks in sshd.c:

(1) https://github.com/openssh/openssh-portable/blob/master/sshd.c#L249: auth_opts is never freed.

(2) https://github.com/openssh/openssh-portable/blob/master/sshd.c#L2363 compat_pkgalg_proposal yields ownership of the returned "char*", which is never freed thereafter.

Not sure if y'all care about issues like these, so I wanted to check first.