Bug 3293

Summary:	Check if MAX is already defined in memmem.c
Product:	Portable OpenSSH	Reporter:	balu <balu.gajjala>
Component:	Build system	Assignee:	Assigned to nobody <unassigned-bugs>
Status:	CLOSED FIXED
Severity:	minor	CC:	balu.gajjala, dtucker
Priority:	P5
Version:	8.5p1
Hardware:	Other
OS:	Windows 10
Bug Depends on:
Bug Blocks:	3270

Description balu 2021-04-08 11:48:34 AEST

defines.h already defined MAX, MIN. It first checks if MAX is not defined.
In memmem.c, it's assumed MAX is not defined and we define one more time.

https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/defines.h#L487


https://github.com/openssh/openssh-portable/blob/d1bd184046bc310c405f45da3614a1dc5b3e521a/openbsd-compat/memmem.c#L64

Comment 1 Darren Tucker 2021-04-08 13:36:28 AEST

Fixed, thanks for the report.

Comment 2 Damien Miller 2021-04-23 14:57:35 AEST

closing resolved bugs as of 8.6p1 release