Bug 854

Summary: openbsd-compat and "--with-ssl-dir=relative path" fails (if no other openssl installation is found)
Product: Portable OpenSSH Reporter: Markus Germeier <mager>
Component: Build systemAssignee: OpenSSH Bugzilla mailing list <openssh-bugs>
Status: CLOSED FIXED    
Severity: trivial    
Priority: P2    
Version: 3.8.1p1   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 914    
Attachments:
Description Flags
prepend pwd to relative --with-openssl paths djm: ok+

Description Markus Germeier 2004-04-29 03:28:36 AEST
Hello,
there is a bug in the build system when building openbsd-compat, if you
configure e.g. --with-ssl-dir=../openssl and no other openssl is available on
the system:

gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I.. -I. -I./..
-I../openssl/include  -DHAVE_CONFIG_H -c bsd-arc4random.c
In file included from bsd-arc4random.c:17:
../includes.h:183:63: openssl/opensslv.h: No such file or directory
[...]

->grep CPPFLAGS Makefile
CPPFLAGS=-I. -I$(srcdir) -I../openssl/include  $(PATHS) -DHAVE_CONFIG_H
        $(CC) $(CFLAGS) $(CPPFLAGS) -c $<
->grep CPPFLAGS openbsd-compat/Makefile
CPPFLAGS=-I. -I.. -I$(srcdir) -I$(srcdir)/.. -I../openssl/include  -DHAVE_CONFIG_H
        $(CC) $(CFLAGS) $(CPPFLAGS) -c $<

Sure thing there is a "../" missing for the openssl include, as the
openbsd-compat files are one directory down.

Perhaps esoteric, but still a bug. ;-)

Regards
  Markus
Comment 1 Darren Tucker 2004-04-29 23:37:35 AEST
If you want to do that, for now use "--with-ssl-dir=`pwd`/../openssl".
Comment 2 Darren Tucker 2005-02-09 20:21:51 AEDT
Created attachment 810 [details]
prepend pwd to relative --with-openssl paths
Comment 3 Damien Miller 2005-02-09 21:47:39 AEDT
Comment on attachment 810 [details]
prepend pwd to relative --with-openssl paths

this looks sane to me
Comment 4 Darren Tucker 2005-02-09 22:13:09 AEDT
Applied, thanks.
Comment 5 Darren Tucker 2005-03-10 09:07:48 AEDT
With the release of OpenSSH 4.0, these bugs are now closed. For details, see:
http://www.openssh.com/txt/release-4.0