Bug 1033 - Fix compile-time warnings
Summary: Fix compile-time warnings
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: -current
Hardware: All All
: P2 trivial
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-07 16:10 AEST by Darren Tucker
Modified: 2006-10-07 11:40 AEST (History)
0 users

See Also:

Attachments
silence warnings in auth-pam.c (2.95 KB, patch)
2005-05-07 16:16 AEST, Darren Tucker 		no flags Details | Diff
fix warnings in getrrsetbyname.c on Linux (1.33 KB, patch)
2005-05-07 16:23 AEST, Darren Tucker 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darren Tucker 2005-05-07 16:10:22 AEST 
There are some compile-time warnings that could be fixed on various platforms.
Comment 1 Darren Tucker 2005-05-07 16:16:16 AEST 
Created attachment 902 [details]
silence warnings in auth-pam.c

Fixes these warnings in auth-pam.c:
warning: dereferencing type-punned pointer will break strict-aliasing rules
warning: passing arg 3 of `pam_get_item' from incompatible pointer type

The type-punned pointer fix is based on a patch from SuSE's rpm.
Comment 2 Darren Tucker 2005-05-07 16:23:51 AEST 
Created attachment 903 [details]
fix warnings in getrrsetbyname.c on Linux

Fixes these in getrrsetbyname.c, (since glibc has _getshort and _getlong
functions, but doesn't define prototypes for them):

warning: implicit declaration of function `_getshort'
warning: implicit declaration of function `_getlong'
Comment 3 Damien Miller 2005-10-30 11:49:20 AEDT 
Are these still relevant? Hasn't the PAM one been committed already? (leading to...) can we close this bug?
Comment 4 Darren Tucker 2005-10-30 14:08:44 AEDT 
Yes, those are both applied.
Comment 5 Darren Tucker 2006-10-07 11:40:07 AEST 
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.