Bug 1064 - Patch: list valid key types in error message
Summary: Patch: list valid key types in error message
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh-keygen (show other bugs)
Version: 4.1p1
Hardware: All All
: P2 enhancement
Assignee: Assigned to nobody
URL:
Keywords: needs-release-note
Depends on:
Blocks: 1047
  Show dependency treegraph
 
Reported: 2005-07-31 21:39 AEST by Ed Avis
Modified: 2006-10-07 11:41 AEST (History)
0 users

See Also:


Attachments
Patch against openssh-4.1p1 to improve ssh-keygen -t error message (1.25 KB, patch)
2005-07-31 21:41 AEST, Ed Avis
no flags Details | Diff
Default to generating a RSA key (644 bytes, patch)
2005-10-30 12:26 AEDT, Damien Miller
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ed Avis 2005-07-31 21:39:42 AEST
This is a patch to improve the error message from ssh-keygen when you give an
unknown key type.  The new message looks like

% ssh-keygen -t foo
unknown key type foo
known key types are: rsa1, rsa, dsa, ssh-rsa, ssh-dss
Comment 1 Ed Avis 2005-07-31 21:41:26 AEST
Created attachment 944 [details]
Patch against openssh-4.1p1 to improve ssh-keygen -t error message
Comment 2 Damien Miller 2005-10-30 12:26:09 AEDT
Created attachment 1017 [details]
Default to generating a RSA key

I think we are better off just generating a RSA2 key if not key type is specified, like this.
Comment 3 Damien Miller 2005-10-30 12:31:00 AEDT
we have a patch, so put it on the radar.
Comment 4 Damien Miller 2005-10-31 22:12:19 AEDT
patch applied - we now generate a RSA SSH protocol 2 key by default. If people need anything else, then they should read the manpage.
Comment 5 Darren Tucker 2006-10-07 11:41:19 AEST
Change all RESOLVED bug to CLOSED with the exception of the ones fixed post-4.4.