I might have missed this one before, sorry. It's similar to the others and could be resolved the same way, with an extra enum for "invalid": cc-1185 cc: WARNING File = log.c, Line = 71 An enumerated type is mixed with another type. { NULL, 0 } ^ cc-1185 cc: WARNING File = log.c, Line = 88 An enumerated type is mixed with another type. { NULL, 0 } ^ No additional warnings have been introduced, only a few remain that were previously reported and explicitly not fixed.
i'm not sure we want to try to silence every warning for valid C. in the other cases it made sense, i don't really know about this one. but we could add 2 _UNKNOWN enums to silence this.
does this resolve the warnings on SGI? Index: log.c =================================================================== RCS file: /cvs/src/usr.bin/ssh/log.c,v retrieving revision 1.19 diff -u -r1.19 log.c --- log.c 19 Dec 2001 07:18:56 -0000 1.19 +++ log.c 5 Jan 2002 22:50:08 -0000 @@ -65,7 +65,7 @@ { "LOCAL5", SYSLOG_FACILITY_LOCAL5 }, { "LOCAL6", SYSLOG_FACILITY_LOCAL6 }, { "LOCAL7", SYSLOG_FACILITY_LOCAL7 }, - { NULL, 0 } + { NULL, (SyslogFacility)0 } }; static struct { @@ -82,7 +82,7 @@ { "DEBUG1", SYSLOG_LEVEL_DEBUG1 }, { "DEBUG2", SYSLOG_LEVEL_DEBUG2 }, { "DEBUG3", SYSLOG_LEVEL_DEBUG3 }, - { NULL, 0 } + { NULL, (LogLevel)0 } }; static void do_log(LogLevel level, const char *fmt, va_list args);
tom confirmed, commited fix.
Mass change of RESOLVED bugs to CLOSED