Three bugs: - libgen.h doesn't exist on all platforms. - basename() doesn't exist on all platforms. - ioctl(TIOCGPGRP) doesn't exist on all platforms. This is a reintroduced problem since there was another method used on other platforms (calling tcgetpgrp()) when that code was still in scp.c The attached patch solves all three problems, the basename() problem only for Cygwin, the other problems generally by adding tests for libgen.h and tcgetpgrp() to configure.ac.
Created attachment 233 [details] Solves the progressmeter.c build problems
Mostly applied - thanks. I committed everything except for the basename() replacement. Instead, I took the implementation from OpenBSD libc and added it to openbsd-compat. Please test and reopen if I have further broken things :)
Looks good so far but... uhm... shouldn't that be: Index: openbsd-compat/basename.h =================================================================== RCS file: /cvs/openssh_cvs/openbsd-compat/basename.h,v retrieving revision 1.1 diff -p -u -r1.1 basename.h --- openbsd-compat/basename.h 24 Feb 2003 01:55:56 -0000 1.1 +++ openbsd-compat/basename.h 24 Feb 2003 08:17:42 -0000 @@ -6,7 +6,7 @@ #if !defined(HAVE_BASENAME) -char *getcwd(char *pt, size_t size); +char *basename(char *path); #endif /* !defined(HAVE_BASENAME) */ #endif /* _BASENAME_H */
Applied a week or two ago.
Mass change of RESOLVED bugs to CLOSED