Bug 541 - packet_set_interactive typo
Summary: packet_set_interactive typo
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: sshd (show other bugs)
Version: -current
Hardware: All All
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
: 594 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-04-10 01:29 AEST by Chris Bradley
Modified: 2004-04-14 12:24 AEST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Bradley 2003-04-10 01:29:07 AEST
Hi,

In OpenSSH 3.6.1p1, the function packet_set_interactive() in packet.c appears 
to have changed from 3.5p1.  It appears there may be a typographical error.

Specifically, 3.6.1p1 shows:

        /* Only set socket options if using a socket.  */
        if (!packet_connection_is_on_socket())
        if (interactive)
                set_nodelay(connection_in);

when it is probably supposed to say:

        /* Only set socket options if using a socket.  */
        if (!packet_connection_is_on_socket())
           return;
 
        if (interactive)
                set_nodelay(connection_in);

In other words, it appears somebody accidentily deleted the "return" statement 
that was present (and functional) in 3.5p1.  As such, the set_nodelay() only 
gets executed in 3.6.1p1 if the connection is NOT on a socket, which is likely 
not how it was meant to be written.
Comment 1 Ben Lindstrom 2003-04-28 03:56:52 AEST
Correct it was a mistake from a merged patch.  It has been added back into portable tree.  
Thanks. 
Comment 2 Ben Lindstrom 2003-06-17 06:47:33 AEST
*** Bug 594 has been marked as a duplicate of this bug. ***
Comment 3 Damien Miller 2004-04-14 12:24:19 AEST
Mass change of RESOLVED bugs to CLOSED