System is Sparc running Solaris 2.5.1 when typing "make" I get the following error on just about every single .c file compiled, here is a sample: In file included from includes.h:54, from authfd.c:37: /usr/include/netdb.h:195: warning: `struct sockaddr_in' declared inside parameter list /usr/include/netdb.h:195: warning: its scope is only this definition or declaration, which is probably not what you want.
In which header file under /usr/include is "struct sockaddr_in" defined?
it appears to be /usr/include/netinet/in.h
In includes.h, try moving the line "#include <netinet/in.h>" to just before the line "#include <netdb.h>" and see if that stops the errors.
yes that appears to have fixed the problem. Most of the source files build without complaints now. There are a few that have other complaints such as -helper\" -DHAVE_CONFIG_H -c xmalloc.c xmalloc.c: In function `xstrdup': xmalloc.c:66: warning: implicit declaration of function `strlcpy' and misc.c: In function `set_nodelay': misc.c:99: warning: passing arg 4 of `getsockopt' from incompatible pointer type misc.c:109: warning: passing arg 4 of `setsockopt' from incompatible pointer type that are isolated to just a few files. Would you like a list of these?
Bug #565 is for compiler warnings, attach them to it.
Should includes.h be reordered, what's the best order to avoid breaking something else?
make the change and see what breaks :) I think moving netdb.h to below netinet/in.h is pretty safe though.
Moved include of netdb.h: 20030629 - (dtucker) Bug #602: move #include of netdb.h to after in.h (fixes compiler warnings on Solaris 2.5.1).
Mass change of RESOLVED bugs to CLOSED