Bug 607 - OpenSSH 3.6.1p1 adding CRs, hurting CVS client/server communications
Summary: OpenSSH 3.6.1p1 adding CRs, hurting CVS client/server communications
Status: CLOSED WORKSFORME
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: ssh (show other bugs)
Version: 3.6.1p2
Hardware: All All
: P2 critical
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-06-27 02:23 AEST by toscani
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description toscani 2003-06-27 02:23:21 AEST 
Currently using OpenSSH under CygWin on an XP box to communicate with a CVS 
server on a Linux box.  Recently upgraded OpenSSH to v3.6.1p1 (the latest 
available under CygWin), and now CVS client/server communications don't work.

I've tracked the problem to what I think (by process of elimination) is a 
new "feature" in OpenSSH whereby it converts LF to CR+LF line terminators.  
This pretty much hoses client/server communications, as the SSH server 
interprets all incoming lines as byte strings including a CR at the 
end...especially bad for pathname interpretation, but lots of other things may 
be affected as well.  I've tried altering the SSH server code to eat the extra 
CRs, but too many other things are broken (including file data exchange I'd 
bet...can't tell which CRs are valid and which are inserted by SSH) for that 
to be effective.
Comment 1 Markus Friedl 2003-06-27 02:40:14 AEST 
i cannot reproduce this. i use cvs over openssh all
the time (since october 1999) and never see these problems.

if \r appears, then you probably allocate extra TTYs.

for ssh over cvs no TTYs should be allocated.
Comment 2 Damien Miller 2004-04-14 12:24:19 AEST 
Mass change of RESOLVED bugs to CLOSED