Bug 706 - newlines missing in PAM conversations
Summary: newlines missing in PAM conversations
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: PAM support (show other bugs)
Version: 3.7.1p1
Hardware: All Solaris
: P2 minor
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-09-23 23:04 AEST by Paul Bolton
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:


Attachments
fix (351 bytes, patch)
2003-09-23 23:06 AEST, Paul Bolton
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Bolton 2003-09-23 23:04:34 AEST
From the manpage pam_start(3PAM):

"It is the responsibility of  the  conversation  function  to
     strip  off   NEWLINE  characters for PAM_PROMPT_ECHO_OFF and
     PAM_PROMPT_ECHO_ON message styles, and to add NEWLINE  char-
     acters  (if appropriate) for PAM_ERROR_MSG and PAM_TEXT_INFO
     message styles."

In auth-pam.c sshpam_thread_conv() and sshpam_query() in the PAM_ERROR_MSG and
PAM_TEXT_INFO messages do not append a newline. pam_chauthtok_conv() does.
Comment 1 Paul Bolton 2003-09-23 23:06:42 AEST
Created attachment 458 [details]
fix
Comment 2 Darren Tucker 2003-11-20 00:07:50 AEDT
This has been fixed in -current, thanks.
Comment 3 Damien Miller 2004-04-14 12:24:19 AEST
Mass change of RESOLVED bugs to CLOSED