Bug 809 - ssh-keyscan breaks too obscurely when remote isn't an SSH server
Summary: ssh-keyscan breaks too obscurely when remote isn't an SSH server
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Miscellaneous (show other bugs)
Version: 3.8p1
Hardware: All Linux
: P2 normal
Assignee: OpenSSH Bugzilla mailing list
URL: http://bugs.debian.org/228828
Keywords:
Depends on:
Blocks:
 
Reported: 2004-03-07 23:49 AEDT by Colin Watson
Modified: 2004-04-14 12:24 AEST (History)
0 users

See Also:

Attachments
Initialize remote_major and remote_minor for each connection (532 bytes, patch)
2004-03-07 23:52 AEDT, Colin Watson 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Colin Watson 2004-03-07 23:49:01 AEDT 
When you ask ssh-keyscan to scan something that isn't an SSH server, it
sometimes fatals before scanning the rest of the list, rather than printing a
debug message and continuing as it's supposed to. This appears to be because
remote_major and remote_minor aren't initialized in congreet(), so if the
sscanf() for the SSH version banner fails then they just contain whatever
happens to be on the stack.

A patch will follow in a moment.
Comment 1 Colin Watson 2004-03-07 23:52:45 AEDT 
Created attachment 570 [details]
Initialize remote_major and remote_minor for each connection
Comment 2 Damien Miller 2004-03-08 20:35:37 AEDT 
Applied - thanks.
Comment 3 Damien Miller 2004-04-14 12:24:20 AEST 
Mass change of RESOLVED bugs to CLOSED