Bug 854 - openbsd-compat and "--with-ssl-dir=relative path" fails (if no other openssl installation is found)
Summary: openbsd-compat and "--with-ssl-dir=relative path" fails (if no other openssl ...
Status: CLOSED FIXED
Alias: None
Product: Portable OpenSSH
Classification: Unclassified
Component: Build system (show other bugs)
Version: 3.8.1p1
Hardware: All All
: P2 trivial
Assignee: OpenSSH Bugzilla mailing list
URL:
Keywords:
Depends on:
Blocks: 914
  Show dependency tree / graph
 
Reported: 2004-04-29 03:28 AEST by Markus Germeier
Modified: 2005-03-10 09:07 AEDT (History)
0 users

See Also:

Attachments
prepend pwd to relative --with-openssl paths (697 bytes, patch)
2005-02-09 20:21 AEDT, Darren Tucker 		djm: ok+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Germeier 2004-04-29 03:28:36 AEST 
Hello,
there is a bug in the build system when building openbsd-compat, if you
configure e.g. --with-ssl-dir=../openssl and no other openssl is available on
the system:

gcc -g -O2 -Wall -Wpointer-arith -Wno-uninitialized -I. -I.. -I. -I./..
-I../openssl/include  -DHAVE_CONFIG_H -c bsd-arc4random.c
In file included from bsd-arc4random.c:17:
../includes.h:183:63: openssl/opensslv.h: No such file or directory
[...]

->grep CPPFLAGS Makefile
CPPFLAGS=-I. -I$(srcdir) -I../openssl/include  $(PATHS) -DHAVE_CONFIG_H
        $(CC) $(CFLAGS) $(CPPFLAGS) -c $<
->grep CPPFLAGS openbsd-compat/Makefile
CPPFLAGS=-I. -I.. -I$(srcdir) -I$(srcdir)/.. -I../openssl/include  -DHAVE_CONFIG_H
        $(CC) $(CFLAGS) $(CPPFLAGS) -c $<

Sure thing there is a "../" missing for the openssl include, as the
openbsd-compat files are one directory down.

Perhaps esoteric, but still a bug. ;-)

Regards
  Markus
Comment 1 Darren Tucker 2004-04-29 23:37:35 AEST 
If you want to do that, for now use "--with-ssl-dir=`pwd`/../openssl".
Comment 2 Darren Tucker 2005-02-09 20:21:51 AEDT 
Created attachment 810 [details]
prepend pwd to relative --with-openssl paths
Comment 3 Damien Miller 2005-02-09 21:47:39 AEDT 
Comment on attachment 810 [details]
prepend pwd to relative --with-openssl paths

this looks sane to me
Comment 4 Darren Tucker 2005-02-09 22:13:09 AEDT 
Applied, thanks.
Comment 5 Darren Tucker 2005-03-10 09:07:48 AEDT 
With the release of OpenSSH 4.0, these bugs are now closed. For details, see:
http://www.openssh.com/txt/release-4.0