Attachment 1158 Details for Bug 1207 – Always call loginsuccess immediately after authentication + report previous correctly

[patch] Always call loginsuccess immediately after authentication + report previous correctly

openssh-4.3p1-aix-badloginclear.patch (text/plain), 1.47 KB, created by Darren Tucker on 2006-07-08 10:47:40 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Darren Tucker

Created: 2006-07-08 10:47:40 AEST

Size: 1.47 KB

patch

obsolete

>Index: auth.c
>===================================================================
>RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/auth.c,v
>retrieving revision 1.110
>diff -u -r1.110 auth.c
>--- auth.c	21 May 2006 08:26:40 -0000	1.110
>+++ auth.c	8 Jul 2006 00:31:01 -0000
>@@ -269,6 +269,11 @@
> 	    strcmp(method, "challenge-response") == 0))
> 		record_failed_login(authctxt->user,
> 		    get_canonical_hostname(options.use_dns), "ssh");
>+# ifdef _AIX
>+	if (authenticated)
>+		sys_auth_record_login(authctxt->user,
>+		    get_canonical_hostname(options.use_dns), "ssh", &loginmsg);
>+# endif
> #endif
> #ifdef SSH_AUDIT_EVENTS
> 	if (authenticated == 0 && !authctxt->postponed)
>Index: openbsd-compat/port-aix.c
>===================================================================
>RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/port-aix.c,v
>retrieving revision 1.33
>diff -u -r1.33 port-aix.c
>--- openbsd-compat/port-aix.c	29 May 2005 00:54:28 -0000	1.33
>+++ openbsd-compat/port-aix.c	8 Jul 2006 00:40:27 -0000
>@@ -256,15 +256,17 @@
>     Buffer *loginmsg)
> {
> 	char *msg = NULL;
>+	static int msg_done = 0;
> 	int success = 0;
> 
> 	aix_setauthdb(user);
> 	if (loginsuccess((char *)user, (char *)host, (char *)ttynm, &msg) == 0) {
> 		success = 1;
>-		if (msg != NULL) {
>+		if (msg != NULL && loginmsg != NULL && !msg_done) {
> 			debug("AIX/loginsuccess: msg %s", msg);
> 			buffer_append(loginmsg, msg, strlen(msg));
> 			xfree(msg);
>+			msg_done = 1;
> 		}
> 	}
> 	aix_restoreauthdb();

Actions: View | Diff

Attachments on bug 1207: 1153 | 1157 | 1158