Attachment 1301 Details for Bug 1320 – Patch against CVS

[patch] Patch against CVS

openssh-patch (text/plain), 11.75 KB, created by Simon Vallet on 2007-06-11 23:54:47 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Simon Vallet

Created: 2007-06-11 23:54:47 AEST

Size: 11.75 KB

patch

obsolete

>Index: configure.ac
>===================================================================
>RCS file: /cvs/openssh/configure.ac,v
>retrieving revision 1.381
>diff -a -u -r1.381 configure.ac
>--- configure.ac	11 Jun 2007 04:15:43 -0000	1.381
>+++ configure.ac	11 Jun 2007 13:45:07 -0000
>@@ -1145,6 +1145,41 @@
> 	]
> )
> 
>+# Check whether user wants to use ldns
>+LDNS_MSG="no"
>+AC_ARG_WITH(ldns,
>+	[  --with-ldns[[=PATH]]      Use ldns for DNSSEC support (optionally in PATH)],
>+    [
>+        if test "x$withval" != "xno" ; then
>+
>+			if test "x$withval" != "xyes" ; then
>+				CPPFLAGS="$CPPFLAGS -I${withval}/include"
>+				LDFLAGS="$LDFLAGS -L${withval}/lib"
>+			fi
>+
>+            AC_DEFINE(HAVE_LDNS, 1, [Define if you want ldns support])
>+            LIBS="-lldns $LIBS"
>+            LDNS_MSG="yes"
>+
>+            AC_MSG_CHECKING([for ldns support])
>+            AC_LINK_IFELSE(
>+                [AC_LANG_SOURCE([[
>+#include <stdio.h>
>+#include <stdlib.h>
>+#include <stdint.h>
>+#include <ldns/ldns.h>
>+int main() { ldns_status status = ldns_verify_trusted(NULL, NULL, NULL, NULL); status=LDNS_STATUS_OK; exit(0); }
>+                                ]])
>+                ],
>+				[AC_MSG_RESULT(yes)],
>+				[
>+					AC_MSG_RESULT(no)
>+					AC_MSG_ERROR([** Incomplete or missing ldns libraries.])
>+				])
>+        fi
>+    ]
>+)
>+
> # Check whether user wants libedit support
> LIBEDIT_MSG="no"
> AC_ARG_WITH(libedit,
>Index: openbsd-compat/Makefile.in
>===================================================================
>RCS file: /cvs/openssh/openbsd-compat/Makefile.in,v
>retrieving revision 1.40
>diff -a -u -r1.40 Makefile.in
>--- openbsd-compat/Makefile.in	30 Aug 2006 17:24:41 -0000	1.40
>+++ openbsd-compat/Makefile.in	11 Jun 2007 13:45:07 -0000
>@@ -18,7 +18,7 @@
> 
> OPENBSD=base64.o basename.o bindresvport.o daemon.o dirname.o getcwd.o getgrouplist.o getopt.o getrrsetbyname.o glob.o inet_aton.o inet_ntoa.o inet_ntop.o mktemp.o readpassphrase.o realpath.o rresvport.o setenv.o setproctitle.o sha2.o sigact.o strlcat.o strlcpy.o strmode.o strsep.o strtonum.o strtoll.o strtoul.o vis.o
> 
>-COMPAT=bsd-arc4random.o bsd-asprintf.o bsd-closefrom.o bsd-cray.o bsd-cygwin_util.o bsd-getpeereid.o bsd-misc.o bsd-nextstep.o bsd-openpty.o bsd-snprintf.o bsd-waitpid.o fake-rfc2553.o openssl-compat.o xmmap.o xcrypt.o
>+COMPAT=bsd-arc4random.o bsd-asprintf.o bsd-closefrom.o bsd-cray.o bsd-cygwin_util.o bsd-getpeereid.o bsd-getrrsetbyname.o bsd-misc.o bsd-nextstep.o bsd-openpty.o bsd-snprintf.o bsd-waitpid.o fake-rfc2553.o openssl-compat.o xmmap.o xcrypt.o
> 
> PORTS=port-aix.o port-irix.o port-linux.o port-solaris.o port-tun.o port-uw.o
> 
>Index: openbsd-compat/bsd-getrrsetbyname.c
>===================================================================
>RCS file: openbsd-compat/bsd-getrrsetbyname.c
>diff -N openbsd-compat/bsd-getrrsetbyname.c
>--- /dev/null	1 Jan 1970 00:00:00 -0000
>+++ openbsd-compat/bsd-getrrsetbyname.c	11 Jun 2007 13:45:07 -0000
>@@ -0,0 +1,294 @@
>+/* $OpenBSD: getrrsetbyname.c,v 1.10 2005/03/30 02:58:28 tedu Exp $ */
>+
>+/*
>+ * Copyright (c) 2007 Simon Vallet / Genoscope <svallet@genoscope.cns.fr>
>+ *
>+ * Redistribution and use in source and binary forms, with or without
>+ * modification, are permitted provided that the following conditions
>+ * are met:
>+ *
>+ * 1. Redistributions of source code must retain the above copyright
>+ *    notice, this list of conditions and the following disclaimer.
>+ *
>+ * 2. Redistributions in binary form must reproduce the above copyright
>+ *    notice, this list of conditions and the following disclaimer in the
>+ *    documentation and/or other materials provided with the distribution.
>+ *
>+ * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
>+ * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
>+ * OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
>+ * IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
>+ * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
>+ * NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
>+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
>+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
>+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
>+ * THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
>+ */
>+
>+/*
>+ * Portions Copyright (c) 1999-2001 Internet Software Consortium.
>+ *
>+ * Permission to use, copy, modify, and distribute this software for any
>+ * purpose with or without fee is hereby granted, provided that the above
>+ * copyright notice and this permission notice appear in all copies.
>+ *
>+ * THE SOFTWARE IS PROVIDED "AS IS" AND INTERNET SOFTWARE CONSORTIUM
>+ * DISCLAIMS ALL WARRANTIES WITH REGARD TO THIS SOFTWARE INCLUDING ALL
>+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS. IN NO EVENT SHALL
>+ * INTERNET SOFTWARE CONSORTIUM BE LIABLE FOR ANY SPECIAL, DIRECT,
>+ * INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER RESULTING
>+ * FROM LOSS OF USE, DATA OR PROFITS, WHETHER IN AN ACTION OF CONTRACT,
>+ * NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF OR IN CONNECTION
>+ * WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
>+ */
>+
>+#include "includes.h"
>+
>+#if !defined (HAVE_GETRRSETBYNAME) && defined (HAVE_LDNS)
>+
>+#include <stdlib.h>
>+#include <string.h>
>+
>+#include <ldns/ldns.h>
>+
>+#include "getrrsetbyname.h"
>+
>+/* We don't need multithread support here */
>+#ifdef _THREAD_PRIVATE
>+# undef _THREAD_PRIVATE
>+#endif
>+#define _THREAD_PRIVATE(a,b,c) (c)
>+
>+int
>+getrrsetbyname(const char *hostname, unsigned int rdclass,
>+	       unsigned int rdtype, unsigned int flags,
>+	       struct rrsetinfo **res)
>+{
>+	int result; unsigned int i; unsigned int j;
>+	struct rrsetinfo *rrset = NULL;
>+  
>+	unsigned int index_ans; unsigned int  index_sig;
>+	struct rdatainfo *rdata;
>+  
>+	ldns_resolver * ldns_res;
>+	ldns_rdf * domain = NULL;  ldns_pkt * pkt;
>+	ldns_rr_list * rrsigs = NULL;
>+	ldns_rr_list * rrdata = NULL;
>+	ldns_status err;
>+	ldns_rr * rr;
>+  
>+	/* check for invalid class and type */
>+	if (rdclass > 0xffff || rdtype > 0xffff) {
>+		result = ERRSET_INVAL;
>+		goto fail;
>+	}
>+  
>+	/* don't allow queries of class or type ANY */
>+	if (rdclass == 0xff || rdtype == 0xff) {
>+		result = ERRSET_INVAL;
>+		goto fail;
>+	}
>+  
>+	/* don't allow flags yet, unimplemented */
>+	if (flags) {
>+		result = ERRSET_INVAL;
>+		goto fail;
>+	}
>+  
>+	/* Initialize resolver from resolv.conf */
>+	domain = ldns_dname_new_frm_str(hostname);
>+	if ((err = ldns_resolver_new_frm_file(&ldns_res, NULL)) != \
>+	    LDNS_STATUS_OK) { 
>+
>+		result = ERRSET_FAIL;
>+		goto fail;
>+	}
>+
>+#ifdef DEBUG
>+	ldns_resolver_set_debug(ldns_res, true);
>+#endif /* DEBUG */
>+
>+	ldns_resolver_set_dnssec(ldns_res, true); /* Use DNSSEC */
>+
>+	/* make query */
>+	pkt = ldns_resolver_query(ldns_res, domain, rdtype, rdclass, LDNS_RD);
>+	
>+	/*** TODO: finer errcodes -- see original **/
>+	if (!pkt || ldns_pkt_ancount(pkt) < 1) {
>+		result = ERRSET_FAIL;
>+		goto fail;
>+	}
>+  
>+	/* initialize rrset */
>+	rrset = calloc(1, sizeof(struct rrsetinfo));
>+	if (rrset == NULL) {
>+		result = ERRSET_NOMEMORY;
>+		goto fail;
>+	}
>+  
>+	rrdata = ldns_pkt_rr_list_by_type(pkt, rdtype, LDNS_SECTION_ANSWER);
>+	rrset->rri_nrdatas = ldns_rr_list_rr_count(rrdata);
>+	if (!rrset->rri_nrdatas) {
>+		result = ERRSET_NODATA;
>+		goto fail;
>+	}
>+
>+	/* copy name from answer section */
>+	rrset->rri_name = strndup(
>+	    ldns_rdf_data(ldns_rr_owner(ldns_rr_list_rr(rrdata, 0))),
>+	    ldns_rdf_size(ldns_rr_owner(ldns_rr_list_rr(rrdata, 0))));
>+
>+	if (rrset->rri_name == NULL) {
>+		result = ERRSET_NOMEMORY;
>+		goto fail;
>+	}
>+
>+	rrset->rri_rdclass = ldns_rr_get_class(ldns_rr_list_rr(rrdata, 0));
>+	rrset->rri_rdtype = ldns_rr_get_type(ldns_rr_list_rr(rrdata, 0));
>+	rrset->rri_ttl = ldns_rr_ttl(ldns_rr_list_rr(rrdata, 0));
>+  
>+	debug2("ldns: got %u answers from DNS", rrset->rri_nrdatas);
>+  
>+	/* Check for authenticated data */
>+	if (ldns_pkt_ad(pkt)) {
>+		rrset->rri_flags |= RRSET_VALIDATED;
>+	} else { /* AD is not set, try autonomous validation */
>+
>+		ldns_rr_list * trusted_keys = ldns_rr_list_new();
>+
>+		debug2("ldns: trying to validate RRset");
>+		/* Get eventual sigs */
>+		rrsigs = ldns_pkt_rr_list_by_type(pkt, LDNS_RR_TYPE_RRSIG, 
>+						  LDNS_SECTION_ANSWER);
>+		
>+		rrset->rri_nsigs = ldns_rr_list_rr_count(rrsigs);
>+		debug2("ldns: got %u signature(s) (RRTYPE %u) from DNS", 
>+		       rrset->rri_nsigs, LDNS_RR_TYPE_RRSIG);
>+
>+		if ((err = ldns_verify_trusted(ldns_res, rrdata, rrsigs, 
>+					       trusted_keys)) == LDNS_STATUS_OK) {
>+
>+			rrset->rri_flags |= RRSET_VALIDATED;
>+			debug2("ldns: RRset is signed with a valid key");
>+		} else {
>+			debug2("ldns: RRset validation failed: %s", 
>+			       ldns_get_errorstr_by_id(err));
>+		}
>+
>+		ldns_rr_list_deep_free(trusted_keys);
>+	}
>+
>+	/* allocate memory for answers */
>+	rrset->rri_rdatas = calloc(rrset->rri_nrdatas, 
>+				   sizeof(struct rdatainfo));
>+
>+	if (rrset->rri_rdatas == NULL) {
>+		result = ERRSET_NOMEMORY;
>+		goto fail;
>+	}
>+
>+	/* allocate memory for signatures */
>+	if (rrset->rri_nsigs > 0) {
>+		rrset->rri_sigs = calloc(rrset->rri_nsigs, 
>+					 sizeof(struct rdatainfo));
>+
>+		if (rrset->rri_sigs == NULL) {
>+			result = ERRSET_NOMEMORY;
>+			goto fail;
>+		}
>+	}
>+
>+	/* copy answers & signatures */
>+	for (i=0, index_ans=0, index_sig=0; i< pkt->_header->_ancount; i++) {
>+	
>+		rdata = NULL;
>+		rr = ldns_rr_list_rr(ldns_pkt_answer(pkt), i);
>+	
>+		if (ldns_rr_get_class(rr) == rrset->rri_rdclass && 
>+		    ldns_rr_get_type(rr) == rrset->rri_rdtype) {
>+
>+			rdata = &rrset->rri_rdatas[index_ans++];
>+		}
>+	
>+		if (rr->_rr_class == rrset->rri_rdclass && 
>+		    rr->_rr_type == LDNS_RR_TYPE_RRSIG) {
>+
>+			rdata = &rrset->rri_sigs[index_sig++];
>+		}
>+	
>+		if (rdata) {
>+			size_t rdata_offset = 0;
>+	  
>+			rdata->rdi_length = 0;
>+			for (j=0; j< rr->_rd_count; j++) {
>+				rdata->rdi_length += \
>+				    ldns_rdf_size(ldns_rr_rdf(rr, j));
>+			}
>+	  
>+			rdata->rdi_data = malloc(rdata->rdi_length);
>+			if (rdata->rdi_data == NULL) {
>+				result = ERRSET_NOMEMORY;
>+				goto fail;
>+			}
>+	  
>+			/* Re-create the raw DNS RDATA */
>+			for (j=0; j< rr->_rd_count; j++) {
>+				memcpy(rdata->rdi_data + rdata_offset, 
>+				       ldns_rdf_data(ldns_rr_rdf(rr, j)), 
>+				       ldns_rdf_size(ldns_rr_rdf(rr, j)));
>+
>+				rdata_offset += ldns_rdf_size(ldns_rr_rdf(rr, j));
>+			}
>+		}
>+	
>+	}
>+  
>+	*res = rrset;
>+	result = ERRSET_SUCCESS;
>+
>+fail:
>+	/* freerrset(rrset); */
>+	ldns_rdf_deep_free(domain);
>+	ldns_pkt_free(pkt);
>+	ldns_rr_list_deep_free(rrsigs);
>+	ldns_rr_list_deep_free(rrdata);
>+	ldns_resolver_deep_free(ldns_res);
>+
>+	return result;
>+}
>+
>+
>+void
>+freerrset(struct rrsetinfo *rrset)
>+{
>+	u_int16_t i;
>+
>+	if (rrset == NULL)
>+		return;
>+
>+	if (rrset->rri_rdatas) {
>+		for (i = 0; i < rrset->rri_nrdatas; i++) {
>+			if (rrset->rri_rdatas[i].rdi_data == NULL)
>+				break;
>+			free(rrset->rri_rdatas[i].rdi_data);
>+		}
>+		free(rrset->rri_rdatas);
>+	}
>+
>+	if (rrset->rri_sigs) {
>+		for (i = 0; i < rrset->rri_nsigs; i++) {
>+			if (rrset->rri_sigs[i].rdi_data == NULL)
>+				break;
>+			free(rrset->rri_sigs[i].rdi_data);
>+		}
>+		free(rrset->rri_sigs);
>+	}
>+
>+	if (rrset->rri_name)
>+		free(rrset->rri_name);
>+	free(rrset);
>+}
>+
>+
>+#endif /* !defined (HAVE_GETRRSETBYNAME) && defined (HAVE_LDNS) */
>Index: openbsd-compat/getrrsetbyname.c
>===================================================================
>RCS file: /cvs/openssh/openbsd-compat/getrrsetbyname.c,v
>retrieving revision 1.24
>diff -a -u -r1.24 getrrsetbyname.c
>--- openbsd-compat/getrrsetbyname.c	29 Apr 2007 03:58:07 -0000	1.24
>+++ openbsd-compat/getrrsetbyname.c	11 Jun 2007 13:45:07 -0000
>@@ -47,7 +47,7 @@
> 
> #include "includes.h"
> 
>-#ifndef HAVE_GETRRSETBYNAME
>+#if !defined (HAVE_GETRRSETBYNAME) && !defined (HAVE_LDNS)
> 
> #include <stdlib.h>
> #include <string.h>
>@@ -607,4 +607,4 @@
> 	return (n);
> }
> 
>-#endif /* !defined(HAVE_GETRRSETBYNAME) */
>+#endif /*  !defined (HAVE_GETRRSETBYNAME) && !defined (HAVE_LDNS) */

Actions: View | Diff

Attachments on bug 1320: 1301 | 1761 | 2095