Bugzilla – Attachment 1362 Details for
Bug 1375
sftp-client leaks handles on failure to open local file
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
do_close(handle) on local file open failure
sftp-close-more.patch (text/plain), 570 bytes, created by
Scott Worley
on 2007-10-16 04:20:03 AEST
(
hide
)
Description:
do_close(handle) on local file open failure
Filename:
MIME Type:
Creator:
Scott Worley
Created:
2007-10-16 04:20:03 AEST
Size:
570 bytes
patch
obsolete
>Without this do_close() I get "Couldn't get handle: Failure" >on every operation after N times through this failure path >where N = 100 on OpenBSD and N = 200 on GNU/Linux. >--- src/usr.bin/ssh/sftp-client.c.orig Sun Sep 16 00:55:52 2007 >+++ src/usr.bin/ssh/sftp-client.c Mon Oct 15 10:12:50 2007 >@@ -813,6 +813,7 @@ do_download(struct sftp_conn *conn, char > if (local_fd == -1) { > error("Couldn't open local file \"%s\" for writing: %s", > local_path, strerror(errno)); >+ do_close(conn, handle, handle_len); > buffer_free(&msg); > xfree(handle); > return(-1);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1362">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1375
: 1362