Bugzilla – Attachment 1500 Details for
Bug 1462
Unaligned access warnings on IA64 when using umac-64
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Force nh_result to 64-bit boundary. (Take 2)
openssh-umac-unaligned.diff (text/plain), 901 bytes, created by
Iain Morgan
on 2008-05-10 10:56:16 AEST
(
hide
)
Description:
Force nh_result to 64-bit boundary. (Take 2)
Filename:
MIME Type:
Creator:
Iain Morgan
Created:
2008-05-10 10:56:16 AEST
Size:
901 bytes
patch
obsolete
>Fix an unaligned access issue observed on Itanium, >but which may affect other platforms as well. >Fix created by Dale Talcott. > >diff -uar umac.c.orig umac.c >--- umac.c.orig 2007-09-16 23:11:02.000000000 -0700 >+++ umac.c 2008-04-11 10:40:31.000000000 -0700 >@@ -1043,7 +1043,8 @@ > */ > { > UWORD bytes_hashed, bytes_remaining; >- UINT8 nh_result[STREAMS*sizeof(UINT64)]; >+ UINT64 result_buf[STREAMS]; >+ UINT8 *nh_result = (UINT8 *)&result_buf; > > if (ctx->msg_len + len <= L1_KEY_LEN) { > nh_update(&ctx->hash, (UINT8 *)input, len); >@@ -1095,7 +1096,8 @@ > static int uhash_final(uhash_ctx_t ctx, u_char *res) > /* Incorporate any pending data, pad, and generate tag */ > { >- UINT8 nh_result[STREAMS*sizeof(UINT64)]; >+ UINT64 result_buf[STREAMS]; >+ UINT8 *nh_result = (UINT8 *)&result_buf; > > if (ctx->msg_len > L1_KEY_LEN) { > if (ctx->msg_len % L1_KEY_LEN) {
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1500">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1462
:
1499
| 1500