Attachment 1511 Details for Bug 1475 – Limit packet size when talking to Cisco protocol-1 only router

[patch] Limit packet size when talking to Cisco protocol-1 only router

openssh-v1-cisco-bigpacket.patch (text/plain), 2.21 KB, created by Darren Tucker on 2008-06-10 04:21:11 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Darren Tucker

Created: 2008-06-10 04:21:11 AEST

Size: 2.21 KB

patch

obsolete

>I don't do much with routers any more but recently I was configuring a
>Cisco via SSH when my session disconnected while pasting large amounts
>of text.  I'm told this is common.
>
>I've had this patch for a while but I've not been able to test it. If
>anyone is regularly experiencing this kind of issue could you please
>tell me if the attached patch helps?
>
>(The buffer size limit is from me, the IGNOREMSG flag is because PuTTY
>thinks that particular version has it.)
>
>Index: compat.c
>===================================================================
>RCS file: /usr/local/src/security/openssh/cvs/openssh/compat.c,v
>retrieving revision 1.77
>diff -u -p -r1.77 compat.c
>--- compat.c	5 Jan 2007 05:26:46 -0000	1.77
>+++ compat.c	14 Jan 2007 01:08:37 -0000
>@@ -145,6 +145,7 @@ compat_datafellows(const char *version)
> 		  "1.2.22*",		SSH_BUG_IGNOREMSG },
> 		{ "1.3.2*",		/* F-Secure */
> 					SSH_BUG_IGNOREMSG },
>+		{ "Cisco-1.25",		SSH_BUG_BIGV1PACKET|SSH_BUG_IGNOREMSG },
> 		{ "*SSH Compatible Server*",			/* Netscreen */
> 					SSH_BUG_PASSWORDPAD },
> 		{ "*OSU_0*,"
>Index: compat.h
>===================================================================
>RCS file: /usr/local/src/security/openssh/cvs/openssh/compat.h,v
>retrieving revision 1.39
>diff -u -p -r1.39 compat.h
>--- compat.h	5 Jan 2007 05:26:46 -0000	1.39
>+++ compat.h	14 Jan 2007 01:09:01 -0000
>@@ -57,6 +57,7 @@
> #define SSH_BUG_FIRSTKEX	0x00800000
> #define SSH_OLD_FORWARD_ADDR	0x01000000
> #define SSH_BUG_RFWD_ADDR	0x02000000
>+#define SSH_BUG_BIGV1PACKET	0x04000000
> 
> void     enable_compat13(void);
> void     enable_compat20(void);
>Index: sshconnect.c
>===================================================================
>RCS file: /usr/local/src/security/openssh/cvs/openssh/sshconnect.c,v
>retrieving revision 1.174
>diff -u -p -r1.174 sshconnect.c
>--- sshconnect.c	28 Dec 2007 15:43:51 -0000	1.174
>+++ sshconnect.c	9 Jun 2008 18:08:04 -0000
>@@ -560,6 +560,11 @@ ssh_exchange_identification(int timeout_
> 	chop(client_version_string);
> 	chop(server_version_string);
> 	debug("Local version string %.100s", client_version_string);
>+
>+	if (datafellows & SSH_BUG_BIGV1PACKET) {
>+		debug("Found big SSHv1 packet bug, limiting packet size");
>+		packet_set_maxsize(4 * 1024);
>+	}
> }
> 
> /* defaults to 'no' */

Actions: View | Diff

Attachments on bug 1475: 1511