Bugzilla – Attachment 1584 Details for
Bug 1541
sftp: the do_stat() failure is ignored for chown, chgrp ops. in parse_dispatch_command()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
propagate error on failure inside chown/chgrp
sftp-propagate-chown-error.diff (text/plain), 919 bytes, created by
Damien Miller
on 2008-12-08 09:24:52 AEDT
(
hide
)
Description:
propagate error on failure inside chown/chgrp
Filename:
MIME Type:
Creator:
Damien Miller
Created:
2008-12-08 09:24:52 AEDT
Size:
919 bytes
patch
obsolete
>Index: sftp.c >=================================================================== >RCS file: /cvs/src/usr.bin/ssh/sftp.c,v >retrieving revision 1.103 >diff -u -p -r1.103 sftp.c >--- sftp.c 13 Jul 2008 22:16:03 -0000 1.103 >+++ sftp.c 7 Dec 2008 22:23:21 -0000 >@@ -1365,17 +1365,19 @@ parse_dispatch_command(struct sftp_conn > remote_glob(conn, path1, GLOB_NOCHECK, NULL, &g); > for (i = 0; g.gl_pathv[i] && !interrupted; i++) { > if (!(aa = do_stat(conn, g.gl_pathv[i], 0))) { >- if (err != 0 && err_abort) >+ if (err_abort) { >+ err = -1; > break; >- else >+ } else > continue; > } > if (!(aa->flags & SSH2_FILEXFER_ATTR_UIDGID)) { > error("Can't get current ownership of " > "remote file \"%s\"", g.gl_pathv[i]); >- if (err != 0 && err_abort) >+ if (err_abort) { >+ err = -1; > break; >- else >+ } else > continue; > } > aa->flags &= SSH2_FILEXFER_ATTR_UIDGID;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=1584">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1541
: 1584