Bugzilla – Attachment 2131 Details for
Bug 1976
sshd leaks stderr fd when run as 'sshd -D'
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
close-stderr-inet.diff
close-stderr-inet.diff (text/plain), 647 bytes, created by
Damien Miller
on 2012-02-24 11:15:19 AEDT
(
hide
)
Description:
close-stderr-inet.diff
Filename:
MIME Type:
Creator:
Damien Miller
Created:
2012-02-24 11:15:19 AEDT
Size:
647 bytes
patch
obsolete
>Index: sshd.c >=================================================================== >RCS file: /cvs/src/usr.bin/ssh/sshd.c,v >retrieving revision 1.388 >diff -u -p -r1.388 sshd.c >--- sshd.c 30 Sep 2011 21:22:49 -0000 1.388 >+++ sshd.c 24 Feb 2012 00:14:46 -0000 >@@ -985,7 +985,9 @@ server_accept_inetd(int *sock_in, int *s > if ((fd = open(_PATH_DEVNULL, O_RDWR, 0)) != -1) { > dup2(fd, STDIN_FILENO); > dup2(fd, STDOUT_FILENO); >- if (fd > STDOUT_FILENO) >+ if (!log_stderr) >+ dup2(fd, STDERR_FILENO); >+ if (fd > (log_stderr ? STDERR_FILENO : STDOUT_FILENO)) > close(fd); > } > debug("inetd sockets after dupping: %d, %d", *sock_in, *sock_out);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=2131">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 1976
: 2131