Attachment 2254 Details for Bug 2096 – cert_free memory leak fix

[patch] cert_free memory leak fix

cert_free.patch (text/plain), 1.00 KB, created by Mateusz Kocielski on 2013-05-01 20:07:26 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Mateusz Kocielski

Created: 2013-05-01 20:07:26 AEST

Size: 1.00 KB

patch

obsolete

>*** openssh-6.2p1/key.c	2013-01-18 01:44:05.000000000 +0100
>--- openssh-6.2p1-new/key.c	2013-03-25 13:10:36.000000000 +0100
>***************
>*** 178,217 ****
>--- 178,218 ----
>  	key_add_private(k);
>  	return k;
>  }
>  
>  static void
>  cert_free(struct KeyCert *cert)
>  {
>  	u_int i;
>  
>  	buffer_free(&cert->certblob);
>  	buffer_free(&cert->critical);
>  	buffer_free(&cert->extensions);
>  	if (cert->key_id != NULL)
>  		xfree(cert->key_id);
>  	for (i = 0; i < cert->nprincipals; i++)
>  		xfree(cert->principals[i]);
>  	if (cert->principals != NULL)
>  		xfree(cert->principals);
>  	if (cert->signature_key != NULL)
>  		key_free(cert->signature_key);
>+     free(cert);
>  }
>  
>  void
>  key_free(Key *k)
>  {
>  	if (k == NULL)
>  		fatal("key_free: key is NULL");
>  	switch (k->type) {
>  	case KEY_RSA1:
>  	case KEY_RSA:
>  	case KEY_RSA_CERT_V00:
>  	case KEY_RSA_CERT:
>  		if (k->rsa != NULL)
>  			RSA_free(k->rsa);
>  		k->rsa = NULL;
>  		break;
>  	case KEY_DSA:
>  	case KEY_DSA_CERT_V00:
>  	case KEY_DSA_CERT:
>  		if (k->dsa != NULL)

Actions: View | Diff

Attachments on bug 2096: 2254