Bugzilla – Attachment 2281 Details for
Bug 2101
Unaligned memory access on sparc in UMAC implemetation
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug fix based on malloc
openssh-mac-align.patch (text/plain), 934 bytes, created by
Darren Tucker
on 2013-05-31 04:58:19 AEST
(
hide
)
Description:
Bug fix based on malloc
Filename:
MIME Type:
Creator:
Darren Tucker
Created:
2013-05-31 04:58:19 AEST
Size:
934 bytes
patch
obsolete
>Index: mac.c >=================================================================== >RCS file: /cvs/src/usr.bin/ssh/mac.c,v >retrieving revision 1.23 >diff -u -p -r1.23 mac.c >--- mac.c 17 May 2013 00:13:13 -0000 1.23 >+++ mac.c 30 May 2013 18:45:53 -0000 >@@ -165,12 +165,16 @@ mac_init(Mac *mac) > u_char * > mac_compute(Mac *mac, u_int32_t seqno, u_char *data, int datalen) > { >- static u_char m[EVP_MAX_MD_SIZE]; >+ static u_char *m; > u_char b[4], nonce[8]; > >- if (mac->mac_len > sizeof(m)) >+ /* malloc ensures m is longword aligned, which is needed by umac */ >+ if (m == NULL) >+ m = xmalloc(EVP_MAX_MD_SIZE); >+ >+ if (mac->mac_len > EVP_MAX_MD_SIZE) > fatal("mac_compute: mac too long %u %lu", >- mac->mac_len, (u_long)sizeof(m)); >+ mac->mac_len, EVP_MAX_MD_SIZE); > > switch (mac->type) { > case SSH_EVP: >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=2281">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 2101
:
2264
|
2265
|
2266
| 2281