Attachment 2421 Details for Bug 2223 – Patch to add Ed25519 support for SSHFP RRs

[patch] Patch to add Ed25519 support for SSHFP RRs

SSHFP-Ed25519.diff (text/plain), 1.69 KB, created by mancha on 2014-04-08 13:53:27 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: mancha

Created: 2014-04-08 13:53:27 AEST

Size: 1.69 KB

patch

obsolete

>From e5294598607dfc0e6bc87f6833794316c1db2f48 Mon Sep 17 00:00:00 2001
>From: mancha <mancha1 AT zoho DOT com>
>Date: Mon, 07 Apr 2014
>Subject: Add Ed25519 support for SSHFP RRs
>
>OpenSSH 6.5 introduced Ed25519 as a key type. This patch adds support
>for that key in SSHFP resource records. Though not yet assigned by IANA,
>we provisionally assign Ed25519 keys an RR type value of four (4).
>
>References:
>[1] http://tools.ietf.org/html/rfc4255
>[2] http://tools.ietf.org/html/rfc6594
>[3] https://www.iana.org/assignments/dns-sshfp-rr-parameters/dns-sshfp-rr-parameters.txt
>[4] http://tools.ietf.org/html/draft-moonesamy-sshfp-ed25519-01
>
>---
> dns.c        |    5 +++++
> dns.h        |    3 ++-
> ssh-keygen.c |    2 ++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
>--- a/dns.h
>+++ b/dns.h
>@@ -32,7 +32,8 @@ enum sshfp_types {
> 	SSHFP_KEY_RESERVED = 0,
> 	SSHFP_KEY_RSA = 1,
> 	SSHFP_KEY_DSA = 2,
>-	SSHFP_KEY_ECDSA = 3
>+	SSHFP_KEY_ECDSA = 3,
>+	SSHFP_KEY_ED25519 = 4
> };
> 
> enum sshfp_hashes {
>--- a/dns.c
>+++ b/dns.c
>@@ -96,6 +96,11 @@ dns_read_key(u_int8_t *algorithm, u_int8
> 		if (!*digest_type)
> 			*digest_type = SSHFP_HASH_SHA256;
> 		break;
>+	case KEY_ED25519:
>+		*algorithm = SSHFP_KEY_ED25519;
>+		if (!*digest_type)
>+			*digest_type = SSHFP_HASH_SHA256;
>+		break;
> 	default:
> 		*algorithm = SSHFP_KEY_RESERVED; /* 0 */
> 		*digest_type = SSHFP_HASH_RESERVED; /* 0 */
>--- a/ssh-keygen.c
>+++ b/ssh-keygen.c
>@@ -2519,6 +2519,8 @@ main(int argc, char **argv)
> 			    _PATH_HOST_DSA_KEY_FILE, rr_hostname);
> 			n += do_print_resource_record(pw,
> 			    _PATH_HOST_ECDSA_KEY_FILE, rr_hostname);
>+			n += do_print_resource_record(pw,
>+			    _PATH_HOST_ED25519_KEY_FILE, rr_hostname);
> 
> 			if (n == 0)
> 				fatal("no keys found.");

Actions: View | Diff

Attachments on bug 2223: 2420 | 2421