Bugzilla – Attachment 2468 Details for
Bug 2270
AuthenticationMethods - partial success is considered as failure
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
don't increment failures in case of partial success
partial-success-is-not-failure.patch (text/plain), 632 bytes, created by
Petr Lautrbach
on 2014-09-04 23:04:04 AEST
(
hide
)
Description:
don't increment failures in case of partial success
Filename:
MIME Type:
Creator:
Petr Lautrbach
Created:
2014-09-04 23:04:04 AEST
Size:
632 bytes
patch
obsolete
>diff --git a/auth2.c b/auth2.c >index d9b440a..ec0bf12 100644 >--- a/auth2.c >+++ b/auth2.c >@@ -355,8 +355,9 @@ userauth_finish(Authctxt *authctxt, int authenticated, const char *method, > authctxt->success = 1; > } else { > >- /* Allow initial try of "none" auth without failure penalty */ >- if (!authctxt->server_caused_failure && >+ /* Allow initial try of "none" auth without failure penalty >+ * Partial succes is not failure */ >+ if (!authctxt->server_caused_failure && !partial && > (authctxt->attempt > 1 || strcmp(method, "none") != 0)) > authctxt->failures++; > if (authctxt->failures >= options.max_authtries) {
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=2468">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 2270
: 2468