Attachment 2525 Details for Bug 2335 – Make config parser more strict to ip:port values

[patch] Make config parser more strict to ip:port values

0003-RHBZ-1130733-Fix-confusing-behaviour-for-ListenAddre.patch (text/plain), 1.09 KB, created by Jakub Jelen on 2015-01-09 22:10:03 AEDT

(hide)

Description:

Filename:

MIME Type:

Creator: Jakub Jelen

Created: 2015-01-09 22:10:03 AEDT

Size: 1.09 KB

patch

obsolete

>From f89f5d3d7a20b432560344ff85e4cd79843be9a9 Mon Sep 17 00:00:00 2001
>From: Jakub Jelen <jjelen@redhat.com>
>Date: Fri, 9 Jan 2015 11:15:09 +0100
>Subject: [PATCH 3/3] RHBZ#1130733: Fix confusing behaviour for ListenAddress
>
> * Current version accepts ListenAddress ip/port which can be
>   confused with ip/mask and can lead to unexpected errors
>   (for example selinux messages as in above mentioned bugzilla)
> * This function is used only for PermitOpen and ListenAddress
>   which both according to man pages require format ip:port and
>   shouldn't accept ip/port format
>---
> misc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/misc.c b/misc.c
>index 2f11de4..36402d1 100644
>--- a/misc.c
>+++ b/misc.c
>@@ -396,7 +396,7 @@ hpdelim(char **cp)
> 			return NULL;
> 		else
> 			s++;
>-	} else if ((s = strpbrk(s, ":/")) == NULL)
>+	} else if ((s = strpbrk(s, ":")) == NULL)
> 		s = *cp + strlen(*cp); /* skip to end (see first case below) */
> 
> 	switch (*s) {
>@@ -405,7 +405,6 @@ hpdelim(char **cp)
> 		break;
> 
> 	case ':':
>-	case '/':
> 		*s = '\0';	/* terminate */
> 		*cp = s + 1;
> 		break;
>-- 
>2.1.0
>

Actions: View | Diff

Attachments on bug 2335: 2525 | 3137 | 3231