Attachment 2788 Details for Bug 2541 – Patch file for this bug report

[patch] Patch file for this bug report

auth2.c.patch (text/plain), 1.24 KB, created by Bill Parker on 2016-02-15 07:47:20 AEDT

(hide)

Description:

Filename:

MIME Type:

Creator: Bill Parker

Created: 2016-02-15 07:47:20 AEDT

Size: 1.24 KB

patch

obsolete

>--- auth2.c.orig	2016-02-13 18:43:48.284735999 -0800
>+++ auth2.c	2016-02-13 18:50:11.694465404 -0800
>@@ -125,6 +125,7 @@
> 	close(fd);
> 
> 	if (n != len) {
>+		explicit_bzero(banner, sizeof(*banner));
> 		free(banner);
> 		return (NULL);
> 	}
>@@ -159,6 +160,7 @@
> 	userauth_send_banner(banner);
> 
> done:
>+	explicit_bzero(banner, sizeof(*banner));
> 	free(banner);
> }
> 
>@@ -204,6 +206,7 @@
> 		debug("bad service request %s", service);
> 		packet_disconnect("bad service request %s", service);
> 	}
>+	explicit_bzero(service, sizeof(*service))
> 	free(service);
> 	return 0;
> }
>@@ -282,8 +285,11 @@
> 	}
> 	userauth_finish(authctxt, authenticated, method, NULL);
> 
>+	explicit_bzero(service, sizeof(*service));
> 	free(service);
>+	explicit_bzero(user, sizeof(*user));
> 	free(user);
>+	explicit_bzero(method, sizeof(*method));
> 	free(method);
> 	return 0;
> }
>@@ -373,6 +379,7 @@
> 		packet_put_char(partial);
> 		packet_send();
> 		packet_write_wait();
>+		explicit_bzero(methods, sizeof(*methods));
> 		free(methods);
> 	}
> }
>@@ -491,6 +498,7 @@
> 	}
> 	ret = 0;
>  out:
>+	explicit_bzero(omethods, sizeof(*omethods));
> 	free(omethods);
> 	return ret;
> }
>@@ -581,6 +589,7 @@
> 	if (*p == ',')
> 		p++;
> 	*methods = xstrdup(p);
>+	explicit_bzero(omethods, sizeof(*omethods));
> 	free(omethods);
> 	return 1;
> }

Flags:

wp02855: ok?

Actions: View | Diff

Attachments on bug 2541: 2787 | 2788 | 2789