Bugzilla – Attachment 2894 Details for
Bug 2564
ssh_config AddKeysToAgent doesn't set key name/path
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
AddKeysToAgent: Use filename when comment is empty
use_filename_when_comment_is_empty.patch (text/plain), 933 bytes, created by
Vincent Brillault
on 2016-11-23 09:30:29 AEDT
(
hide
)
Description:
AddKeysToAgent: Use filename when comment is empty
Filename:
MIME Type:
Creator:
Vincent Brillault
Created:
2016-11-23 09:30:29 AEDT
Size:
933 bytes
patch
obsolete
>commit ba6eeef0fa4900afcebe48ae93f0f06331fd1644 >Author: Vincent Brillault <git@lerya.net> >Date: Tue Nov 22 23:11:23 2016 +0100 > > AddKeysToAgent: use filename when comment is empty > > This commit dupplicate the behavior of add_file@ssh-add.c when the > comment is NULL or empty. The only difference with that code is the > absence of the xstrdup call, which is not needed as the pointer change > is only local, for functions only using it as a const char*. > > Fix: #2564 > >diff --git a/sshconnect.c b/sshconnect.c >index 96b91ce..664f36c 100644 >--- a/sshconnect.c >+++ b/sshconnect.c >@@ -1529,6 +1529,9 @@ maybe_add_key_to_agent(char *authfile, Key *private, char *comment, > return; > } > >+ if (comment == NULL || *comment == '\0') >+ comment = authfile; >+ > if (options.add_keys_to_agent == 2 && > !ask_permission("Add key %s (%s) to agent?", authfile, comment)) { > debug3("user denied adding this key");
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=2894">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 2564
:
2885
| 2894