Bugzilla – Attachment 3001 Details for
Bug 2734
close() is called twice in confree()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
ssh-keyscan: Close ssh channel FDs only once
ssh-keyscan-close.patch (text/plain), 588 bytes, created by
Darren Tucker
on 2017-06-30 13:37:37 AEST
(
hide
)
Description:
ssh-keyscan: Close ssh channel FDs only once
Filename:
MIME Type:
Creator:
Darren Tucker
Created:
2017-06-30 13:37:37 AEST
Size:
588 bytes
patch
obsolete
>diff --git a/ssh-keyscan.c b/ssh-keyscan.c >index 2767e7d..dc42226 100644 >--- a/ssh-keyscan.c >+++ b/ssh-keyscan.c >@@ -390,7 +390,6 @@ confree(int s) > { > if (s >= maxfd || fdcon[s].c_status == CS_UNUSED) > fatal("confree: attempt to free bad fdno %d", s); >- close(s); > free(fdcon[s].c_namebase); > free(fdcon[s].c_output_name); > if (fdcon[s].c_status == CS_KEYS) >@@ -401,7 +400,8 @@ confree(int s) > ssh_packet_close(fdcon[s].c_ssh); > free(fdcon[s].c_ssh); > fdcon[s].c_ssh = NULL; >- } >+ } else >+ close(s); > TAILQ_REMOVE(&tq, &fdcon[s], c_link); > FD_CLR(s, read_wait); > ncon--;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=3001">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
djm
:
ok+
Actions:
View
|
Diff
Attachments on
bug 2734
: 3001