Bugzilla – Attachment 3050 Details for
Bug 2773
Potential segfault from ssh_remote_ipaddr()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
do not dereference NULL pointer before checking its validity
file_2773.txt (text/plain), 572 bytes, created by
Jakub Jelen
on 2017-09-04 21:00:29 AEST
(
hide
)
Description:
do not dereference NULL pointer before checking its validity
Filename:
MIME Type:
Creator:
Jakub Jelen
Created:
2017-09-04 21:00:29 AEST
Size:
572 bytes
patch
obsolete
>--- packet.c 2017-09-04 12:49:41.086968750 +0200 >+++ packet.c.new 2017-09-04 12:49:35.665934589 +0200 >@@ -510,11 +510,12 @@ > const char * > ssh_remote_ipaddr(struct ssh *ssh) > { >- const int sock = ssh->state->connection_in; >+ const int sock; > > /* Check whether we have cached the ipaddr. */ > if (ssh->remote_ipaddr == NULL) { > if (ssh_packet_connection_is_on_socket(ssh)) { >+ sock = ssh->state->connection_in; > ssh->remote_ipaddr = get_peer_ipaddr(sock); > ssh->remote_port = get_peer_port(sock); > ssh->local_ipaddr = get_local_ipaddr(sock);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=3050">View the attachment on a separate page</a>.</b>
View Attachment As Raw
Actions:
View
Attachments on
bug 2773
: 3050