Attachment 3171 Details for Bug 2898 – Fix memory leak in userauth_pubkey

[patch] Fix memory leak in userauth_pubkey

0001-Fix-memory-leak-in-userauth_pubkey.patch (text/plain), 986 bytes, created by Colin Watson on 2018-08-21 20:24:02 AEST

(hide)

Description:

Filename:

MIME Type:

Creator: Colin Watson

Created: 2018-08-21 20:24:02 AEST

Size: 986 bytes

patch

obsolete

>From 75b40e50a1ab118d091fd092651840eb4a2e2504 Mon Sep 17 00:00:00 2001
>From: Colin Watson <cjwatson@debian.org>
>Date: Tue, 21 Aug 2018 11:20:34 +0100
>Subject: [PATCH] Fix memory leak in userauth_pubkey
>
>OpenBSD commit b4891882fbe413f230fe8ac8a37349b03bd0b70d caused this to
>leak a struct sshbuf if the incoming packet has a signature but the
>current authentication context doesn't have a valid user.
>---
> auth2-pubkey.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/auth2-pubkey.c b/auth2-pubkey.c
>index e1c15040..01bdc389 100644
>--- a/auth2-pubkey.c
>+++ b/auth2-pubkey.c
>@@ -193,7 +193,6 @@ userauth_pubkey(struct ssh *ssh)
> 		    ssh->compat)) == 0) {
> 			authenticated = 1;
> 		}
>-		sshbuf_free(b);
> 		auth2_record_key(authctxt, authenticated, key);
> 	} else {
> 		debug("%s: test pkalg %s pkblob %s%s%s",
>@@ -237,6 +236,7 @@ done:
> 
> 	sshauthopt_free(authopts);
> 	sshkey_free(key);
>+	sshbuf_free(b);
> 	free(userstyle);
> 	free(pkalg);
> 	free(pkblob);
>-- 
>2.18.0
>

Actions: View | Diff

Attachments on bug 2898: 3171