Bugzilla – Attachment 3215 Details for
Bug 2942
minor memory leak in ssh_set_newkeys()
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch to fix memory leak (proposal 1).
newkeys_leak.patch (text/plain), 712 bytes, created by
Markus
on 2018-12-07 21:23:38 AEDT
(
hide
)
Description:
patch to fix memory leak (proposal 1).
Filename:
MIME Type:
Creator:
Markus
Created:
2018-12-07 21:23:38 AEDT
Size:
712 bytes
patch
obsolete
>diff --git a/packet.c b/packet.c >index dcf35e6..3a5a735 100644 >--- a/packet.c >+++ b/packet.c >@@ -858,8 +858,6 @@ ssh_set_newkeys(struct ssh *ssh, int mode) > (unsigned long long)state->p_read.blocks, > (unsigned long long)state->p_send.bytes, > (unsigned long long)state->p_send.blocks); >- cipher_free(*ccp); >- *ccp = NULL; > kex_free_newkeys(state->newkeys[mode]); > state->newkeys[mode] = NULL; > } >@@ -878,6 +876,8 @@ ssh_set_newkeys(struct ssh *ssh, int mode) > } > mac->enabled = 1; > DBG(debug("cipher_init_context: %d", mode)); >+ cipher_free(*ccp); >+ *ccp = NULL; > if ((r = cipher_init(ccp, enc->cipher, enc->key, enc->key_len, > enc->iv, enc->iv_len, crypt_type)) != 0) > return r;
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=3215">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 2942
: 3215