Bugzilla – Attachment 3302 Details for
Bug 2791
Match host exec doesn't resolve SHELL in the PATH
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
check shell is executable to provide better error message
bz2791.diff (text/plain), 640 bytes, created by
Damien Miller
on 2019-07-19 15:51:22 AEST
(
hide
)
Description:
check shell is executable to provide better error message
Filename:
MIME Type:
Creator:
Damien Miller
Created:
2019-07-19 15:51:22 AEST
Size:
640 bytes
patch
obsolete
>commit f1dce8663e1ade569a88285185f07fd257a5d0ac >Author: Damien Miller <djm@mindrot.org> >Date: Fri Jul 19 15:50:34 2019 +1000 > > bz2791 > >diff --git a/readconf.c b/readconf.c >index 27b535e1..188c3d47 100644 >--- a/readconf.c >+++ b/readconf.c >@@ -486,6 +486,11 @@ execute_in_shell(const char *cmd) > if ((shell = getenv("SHELL")) == NULL) > shell = _PATH_BSHELL; > >+ if (access(shell, X_OK) == -1) { >+ fatal("Shell \"%s\" is not executable: %s", >+ shell, strerror(errno)); >+ } >+ > /* Need this to redirect subprocess stdin/out */ > if ((devnull = open(_PATH_DEVNULL, O_RDWR)) == -1) > fatal("open(/dev/null): %s", strerror(errno));
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=3302">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
dtucker
:
ok+
Actions:
View
|
Diff
Attachments on
bug 2791
: 3302