Bugzilla – Attachment 3534 Details for
Bug 1164
scp with spaces username no longer works
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
revised diff; check username only for old-style remote->remote copies
bz1164.diff (text/plain), 840 bytes, created by
Damien Miller
on 2021-07-02 15:23:50 AEST
(
hide
)
Description:
revised diff; check username only for old-style remote->remote copies
Filename:
MIME Type:
Creator:
Damien Miller
Created:
2021-07-02 15:23:50 AEST
Size:
840 bytes
patch
obsolete
>diff --git a/scp.c b/scp.c >index d23f34c17..cea8a2390 100644 >--- a/scp.c >+++ b/scp.c >@@ -915,10 +915,6 @@ toremote(int argc, char **argv) > goto out; > } > } >- if (tuser != NULL && !okname(tuser)) { >- ++errs; >- goto out; >- } > > /* Parse source files */ > for (i = 0; i < argc - 1; i++) { >@@ -953,6 +949,15 @@ toremote(int argc, char **argv) > (void) close(remout); > remin = remout = -1; > } else if (host) { /* standard remote to remote */ >+ /* >+ * Second remote user is passed to first remote side >+ * via scp command-line. Ensure it contains no obvious >+ * shell characters. >+ */ >+ if (tuser != NULL && !okname(tuser)) { >+ ++errs; >+ continue; >+ } > if (tport != -1 && tport != SSH_DEFAULT_PORT) { > /* This would require the remote support URIs */ > fatal("target port not supported with two "
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=3534">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Flags:
dtucker
:
ok+
Actions:
View
|
Diff
Attachments on
bug 1164
:
1085
| 3534