Attachment 3628 Details for Bug 3475 – Avoid fzero-call-used-regs on possibly buggy clang versions

[patch] Avoid fzero-call-used-regs on possibly buggy clang versions

openssh-clang-zero-call-used-reg.patch (text/plain), 1.85 KB, created by Darren Tucker on 2022-11-30 10:43:35 AEDT

(hide)

Description:

Filename:

MIME Type:

Creator: Darren Tucker

Created: 2022-11-30 10:43:35 AEDT

Size: 1.85 KB

patch

obsolete

>diff --git a/configure.ac b/configure.ac
>index d1998c94..65ad069a 100644
>--- a/configure.ac
>+++ b/configure.ac
>@@ -172,6 +172,22 @@ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[int main(void) { return 0; }]])],
> CFLAGS="$saved_CFLAGS"
> 
> if test "$GCC" = "yes" || test "$GCC" = "egcs"; then
>+	AC_MSG_CHECKING([gcc version])
>+	GCC_VER=`$CC -v 2>&1 | $AWK '/gcc version /{print $3}'`
>+	case "$GCC_VER" in
>+		1.*) no_attrib_nonnull=1 ;;
>+		2.8* | 2.9*)
>+		     no_attrib_nonnull=1
>+		     ;;
>+		2.*) no_attrib_nonnull=1 ;;
>+		*) ;;
>+	esac
>+	AC_MSG_RESULT([$GCC_VER])
>+
>+	AC_MSG_CHECKING([clang version])
>+	CLANG_VER=`$CC -v 2>&1 | $AWK '/clang version /{print $3}'`
>+	AC_MSG_RESULT([$CLANG_VER])
>+
> 	OSSH_CHECK_CFLAG_COMPILE([-pipe])
> 	OSSH_CHECK_CFLAG_COMPILE([-Wunknown-warning-option])
> 	OSSH_CHECK_CFLAG_COMPILE([-Wno-error=format-truncation])
>@@ -203,20 +219,15 @@ if test "$GCC" = "yes" || test "$GCC" = "egcs"; then
> 	# actually links. The test program compiled/linked includes a number
> 	# of integer operations that should exercise this.
> 	OSSH_CHECK_CFLAG_LINK([-ftrapv])
>-	OSSH_CHECK_CFLAG_COMPILE([-fzero-call-used-regs=all])
>+	# clang 15 seems to have a big in -fzero-call-used-regs.  See
>+	# https://bugzilla.mindrot.org/show_bug.cgi?id=3475 and
>+	# https://github.com/llvm/llvm-project/issues/59242
>+	case "$CLANG_VER" in
>+	15.*) AC_MSG_WARN([possible clang bug in -fzero-call-used-regs, omitting]);;
>+	*)    OSSH_CHECK_CFLAG_COMPILE([-fzero-call-used-regs=all]) ;;
>+	esac
> 	OSSH_CHECK_CFLAG_COMPILE([-ftrivial-auto-var-init=zero])
>     fi
>-	AC_MSG_CHECKING([gcc version])
>-	GCC_VER=`$CC -v 2>&1 | $AWK '/gcc version /{print $3}'`
>-	case $GCC_VER in
>-		1.*) no_attrib_nonnull=1 ;;
>-		2.8* | 2.9*)
>-		     no_attrib_nonnull=1
>-		     ;;
>-		2.*) no_attrib_nonnull=1 ;;
>-		*) ;;
>-	esac
>-	AC_MSG_RESULT([$GCC_VER])
> 
> 	AC_MSG_CHECKING([if $CC accepts -fno-builtin-memset])
> 	saved_CFLAGS="$CFLAGS"

Flags:

djm: ok+

Actions: View | Diff

Attachments on bug 3475: 3614 | 3628