Bugzilla – Attachment 687 Details for
Bug 897
scp doesn't clean up forked children when processing multiple files
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Requests
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
problem only effects tolocal(). Previous patch broke on toremote copies
scp.c.antizombie.patch2 (text/plain), 850 bytes, created by
Stephen Riehm
on 2004-07-21 00:19:13 AEST
(
hide
)
Description:
problem only effects tolocal(). Previous patch broke on toremote copies
Filename:
MIME Type:
Creator:
Stephen Riehm
Created:
2004-07-21 00:19:13 AEST
Size:
850 bytes
patch
obsolete
>*** scp.c.orig Mon Nov 24 03:09:28 2003 >--- scp.c Tue Jul 20 16:09:24 2004 >*************** >*** 451,457 **** > void > tolocal(int argc, char **argv) > { >! int i, len; > char *bp, *host, *src, *suser; > > for (i = 0; i < argc - 1; i++) { >--- 451,457 ---- > void > tolocal(int argc, char **argv) > { >! int i, len, status; > char *bp, *host, *src, *suser; > > for (i = 0; i < argc - 1; i++) { >*************** >*** 494,499 **** >--- 494,511 ---- > sink(1, argv + argc - 1); > (void) close(remin); > remin = remout = -1; >+ if (do_cmd_pid != -1 && errs == 0) { >+ if (remin != -1) >+ (void) close(remin); >+ if (remout != -1) >+ (void) close(remout); >+ if (waitpid(do_cmd_pid, &status, 0) == -1) >+ errs = 1; >+ else { >+ if (!WIFEXITED(status) || WEXITSTATUS(status) != 0) >+ errs = 1; >+ } >+ } > } > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=687">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 897
:
686
|
687
|
688
|
695