Bug 1262

Summary:

ssh disconnect message from master control is confusing

Product:

Portable OpenSSH

Reporter:

Alexandre Pereira Nunes <alexandre.nunes>

Component:

ssh

Assignee:

Damien Miller <djm>

Status:

CLOSED FIXED

Severity:

trivial

Priority:

Version:

4.3p2

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

1289

Attachments:

Description	Flags
Better error message	dtucker: ok+

Description Alexandre Pereira Nunes 2006-11-14 06:51:20 AEDT

This may seem trivial, but when I disconnect from any host for which I had a previous connection, and the newer connection is using the previously stablished master control, ssh outputs this at disconnection:

Connection to master closed.

The thing is that I happen to have a server called master. So that looks quite ambiguous.

I suggest changing that to the real server's name (as in the control socket name) or to something like "Connection to a master control closed" ...

Comment 1 Damien Miller 2007-06-12 21:35:19 AEST

Created attachment 1305 [details]
Better error message

This patch makes the error message:

"Shared connection to HOSTNAME closed."

Comment 2 Damien Miller 2007-06-12 21:36:53 AEST

Comment on attachment 1305 [details]
Better error message

doh - ignore all but the ssh.c bits in that diff. Some other stuff I was working on got mixed in.

Comment 3 Darren Tucker 2007-06-12 21:40:48 AEST

Comment on attachment 1305 [details]
Better error message

ok for the ssh.c bit.  Rest of the diff looks unintentional.

Comment 4 Damien Miller 2007-06-12 21:45:44 AEST

patch applied - this will be in OpenSSH 4.7, thanks!

Comment 5 Damien Miller 2008-04-04 09:57:20 AEDT

Close resolved bugs after release.