| Summary: | Add support for ldns | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Portable OpenSSH | Reporter: | Simon Vallet <svallet> | ||||||||
| Component: | ssh | Assignee: | Assigned to nobody <unassigned-bugs> | ||||||||
| Status: | CLOSED FIXED | ||||||||||
| Severity: | enhancement | CC: | cjwatson, djm, dtucker | ||||||||
| Priority: | P2 | ||||||||||
| Version: | -current | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | Linux | ||||||||||
| Bug Depends on: | |||||||||||
| Bug Blocks: | 1930 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Vallet
2007-06-11 23:54:47 AEST
(In reply to comment #0) > The patch is against current CVS (and needs a minor adjustment to > config.h.in, which does not seem to be under version control) config.h.in is created by autoconf, so if you need changes then it's autoconf that needs to be changed. What exactly needs to be adjusted? (In reply to comment #1) > (In reply to comment #0) > > The patch is against current CVS (and needs a minor adjustment to > > config.h.in, which does not seem to be under version control) > > config.h.in is created by autoconf, so if you need changes then it's > autoconf that needs to be changed. > > What exactly needs to be adjusted? weirdly I had to manually add the '#undef HAVE_LDNS' to config.h.in. I thought it was automatically added by this macro: AC_DEFINE(HAVE_LDNS, 1, [Define if you want ldns support]) but it seems it was not -- maybe my autoconf's broken in some way. (In reply to comment #2) > weirdly I had to manually add the '#undef HAVE_LDNS' to config.h.in. I > thought it was automatically added by this macro: > > AC_DEFINE(HAVE_LDNS, 1, [Define if you want ldns support]) > > but it seems it was not -- maybe my autoconf's broken in some way. Actually it's the autoheader too which isn't run by autoconf by default. Try running "autoreconf" instead of autoconf, or run "autoheader" as well. (In reply to comment #3) > (In reply to comment #2) > > weirdly I had to manually add the '#undef HAVE_LDNS' to config.h.in. I > > thought it was automatically added by this macro: > > > > AC_DEFINE(HAVE_LDNS, 1, [Define if you want ldns support]) > > > > but it seems it was not -- maybe my autoconf's broken in some way. > > Actually it's the autoheader too which isn't run by autoconf by > default. Try running "autoreconf" instead of autoconf, or run > "autoheader" as well. You're right -- I missed the autoheader part: running autoreconf correctly includes the line in config.h.in Created attachment 1761 [details]
Updated ldns patch
Replaced strndup (a GNUism) with malloc/memcpy. Fixed a few style nits, whitespace and such.
If someone who uses ldns could confirm that the updated patch functions correctly then I'd like to put this in for the next release. Thanks. It was recently brought to my attention (http://bugs.debian.org/572049) that Fedora is shipping a patch purporting to enable DNSSEC with glibc: https://cvs.fedoraproject.org/viewvc/F-12/openssh/openssh-5.2p1-edns.patch?revision=1.1&view=markup Perhaps this is an alternative to depending on another library? (In reply to comment #7) > Perhaps this is an alternative to depending on another library? I have no objection to enabling the support when glibc has it, but glibc is only viable on a subset of the platforms supported by openssh. No test reports, punting to next release. Retarget unclosed bugs from 5.7=>5.8 Retarget unresolved bugs/features to 6.0 release Retarget unresolved bugs/features to 6.0 release Retarget unresolved bugs/features to 6.0 release (try again - bugzilla's "change several" isn't) Created attachment 2095 [details]
Updated ldns patch
Some changes at djm's request:
- renamed bsd-getrrsetbyname.c to getrrsetbyname-ldns.c since it is ldns specific.
- used xmalloc and friends for extra checking (using #define so any future code syncs will be easier).
patch commited, it will be in the openssh 6.0p1 release. Thanks! Close all resolved bugs after 7.3p1 release |